Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns Page: Hide preview column by default #60704

Closed
t-hamano opened this issue Apr 12, 2024 · 2 comments · Fixed by #63213
Closed

Patterns Page: Hide preview column by default #60704

t-hamano opened this issue Apr 12, 2024 · 2 comments · Fixed by #63213
Assignees
@akasunil
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Decision Needs a decision to be actionable or relevant [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@t-hamano
Copy link
Contributor

What problem does this address?

#60337 introduced the table layout on Pattern page. Currently, the pattern preview is displayed and cannot be hidden.

image

What is your proposed solution?

I suggest the following changes:

  • Hide previews by default in the table layout.
  • Can display a preview from the view options menu.

These two match the specifications of the current template page and template parts page.

image
@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Apr 12, 2024
@t-hamano t-hamano mentioned this issue Apr 12, 2024
Closed
@carolinan carolinan added the Needs Decision Needs a decision to be actionable or relevant label Jun 28, 2024
@carolinan
Copy link
Contributor

I agree it makes sense for the table layouts to match better, regardless of what type of item is being viewed.

@akasunil akasunil self-assigned this Jul 6, 2024
@akasunil akasunil mentioned this issue Jul 6, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 6, 2024
@akasunil
Copy link
Member

akasunil commented Jul 6, 2024

Hi @carolinan, I apologies for overlooking the "needs-decision" label. I noticed it after I created the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akasunil akasunil

Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Decision Needs a decision to be actionable or relevant [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patterns Page: Hide preview column by default WordPress/gutenberg
3 participants
@carolinan @t-hamano @akasunil