Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider exposing the Font Library for classic themes #64409

Open
annezazu opened this issue Aug 9, 2024 · 6 comments
Open

Consider exposing the Font Library for classic themes #64409

annezazu opened this issue Aug 9, 2024 · 6 comments
Labels
[Feature] Font Library Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Aug 9, 2024

This has come up in a few places since the launch of the Font Library and, to ensure a dedicated focus for it, I wanted to open a standalone issue about bringing the font library to classic themes, separate from the overall Styles UI (issue here: #41119). As previously noted, the font library was intentionally designed to be similar to the media library. The media library both is available as modal and a dedicated section of the admin interface, which sets a possible precedence for the font library too. In order to bring improved font management to classic themes, this issue seeks to explore what it might look like to bring the font library to classic themes.

@jasmussen
Copy link
Contributor

Here's a quick design that assumes this is mainly uploading and basic adding/removing/managing:

Classic fonts, basic

There's an open question on whether the Google Fonts library can easily be made available here. I'd love some technical feedback on that, CC: @matiasbenedetto. If it's possible/feasible/reasonable to embed the entire contents of the font library modal directly, perhaps it could be integrated like this:

Classic fonts, integrated

A more likely outcome, might be to simply make the modal available from the Appearance > Fonts menu item on the top level, like this:

Classic fonts, with modal

CC: @WordPress/gutenberg-design. Figma.

@jasmussen jasmussen added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Aug 13, 2024
@matiasbenedetto
Copy link
Contributor

What do you think of the method described here to use the font library in classic and hybrid themes?: https://wpdevelopment.courses/articles/font-library-classic-or-hybrid-themes/

@jasmussen
Copy link
Contributor

I think that can technically make it available, though it doesn't seem to address the spirit of this issue.

@t-hamano
Copy link
Contributor

I explored the idea of ​​exposing the Global Styles, including the Font Library, for the classic theme in this comment.

@jasmussen
Copy link
Contributor

Shared an update on #41119 (comment) which possibly enables a different approach to surfacing the font library for classic themes. Feel free to share your thoughts.

@jasmussen
Copy link
Contributor

For anyone following, some related conversation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
Status: Now
Development

No branches or pull requests

4 participants