Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Image block - Lightbox Button position #67042

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Fix: Image block - Lightbox Button position #67042

wants to merge 2 commits into from

Conversation

Takshil-Kunadia
Copy link
Contributor

What?

Fixes: #66958

Why?

The button's absolute positioning, determined by top and right values, is influenced by several factors. However, in some scenarios, the resulting position can be suboptimal.

For a standard Image block, the positioning generally works well. But when the Image block adopts a non-default layout, especially within nested containers, the positioning becomes inconsistent and erratic.

How?

This PR adds on to the logic of calculating the buttons's position relatively to the size of the image inside the figure tag and sets default minimum positions of the button.

Testing Instructions

  1. Create a post and add a Group block and set to a Grid variant.
  2. inside the group block add 6 images with varying sizes/ratio and with and without captions.
  3. Publish and view the front end.
  4. Hover on the images.
  5. Observe the placement of the trigger button.

Testing Instructions for Keyboard

Screenshots or screencast

Screen.Recording.2024-11-15.at.10.08.25.PM.mov

@Takshil-Kunadia
Copy link
Contributor Author

Although, this will take care of 99% of use cases. However, notice the last image. I was blocked as to how to handle the positioning in an extremely small image.

@Takshil-Kunadia Takshil-Kunadia marked this pull request as ready for review November 15, 2024 20:44
@github-actions GitHub Actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

1 similar comment
@github-actions GitHub Actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Takshil-Kunadia <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>
Co-authored-by: luisherranz <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemiomorales artemiomorales Awaiting requested review from artemiomorales artemiomorales is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image block: lightbox trigger misplaced depending on contextual layout
1 participant
@Takshil-Kunadia