Image Block: Replacing Image can alter caption settings

[MadtownLems]

Description

When you have an Image Block (with Caption toggled off), and replace it with an Image from your Media Library that does have a caption, the Image Block gets its Caption setting toggled on (and uses the caption of the new Image block). This doesn't feel like expected behavior at all in typical contexts, and is very annoying when dealing with Block Patterns. Many of our Block Patterns make use of Image Blocks (withOUT captions). When users customize the Pattern with their own Image, a Caption suddenly pops up where nobody intended one to be (and is very easy to miss).

Step-by-step reproduction instructions

1. Insert an Image Block. Make sure its caption is Off.
2. Replace the media with an image from the Media Library that already has a Caption set
3. See that the Image Block gets its Caption setting toggled On (when it was off) and the caption is unexpectedly displayed

Screenshots, screen recording, code snippet

No response

Environment info

WordPress 6.7, no Gutenberg plugin

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[Mayank-Tripathi32]

@MadtownLems I am able to replicate the behavior and suspect it may be intentional; however, it could easily be perceived as a bug from a user’s perspective.

[t-hamano]

While the current behavior is intended, I agree that this is a bit confusing.

Even in the Classic Editor, when you replace an image, the caption for the new image appears.

[MadtownLems]

What's the process for debating making a change here? I think that replacing an image and having the caption show up should never happen - but I REALLY don't think it should happen in the context of a pattern (which I believe is now possible to detect).

…

On Sat, Nov 16, 2024, 3:00 AM Aki Hamano ***@***.***> wrote: While the current behavior is intended, I agree that this is a bit confusing. Even in the Classic Editor, when you replace an image, the caption for the new image appears. — Reply to this email directly, view it on GitHub <#66979 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHGYBOFXJPFQBXLZ2GWG5L2A4CTHAVCNFSM6AAAAABRXKQFN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGQ4DKMRZG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>