Label of button 'Move to trash' on Settings Panel in Block Editor not changed when constant EMPTY_TRASH_DAYS is defined as 0.

[hbhalodia]

Description

1. When adding the constant EMPTY_TRASH_DAYS, to 0, it should show permanent delete option in post editor, instead it shows Move to trash, but the action performed is permanent delete.
2. Core ticket - https://core.trac.wordpress.org/ticket/64453

Step-by-step reproduction instructions

1. Set EMPTY_TRASH_DAYS in wp-config.php to 0.
2. Open post editor, you will see move to trash button, instead it should show Delete Permanently.
3. When clicked Move to trash, it shows modal and says move to trash for confirmation, but when done, the post is deleted permanently instead of trash which is ideal behaviour, but labels are mismatched.

Screenshots, screen recording, code snippet

Screen.Recording.2025-12-26.at.1.39.57.PM.mov

Environment info

• WordPress Trunk.
• GB Trunk.

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[hbhalodia]

Related - #13024 (comment)

[hbhalodia]

Hi @t-hamano, Is there any way to expose/add this constant value to GB store or somewhere that we can use to change the labels? I tried checking, but I am not aware of any such place where we can expose this in GB store/settings.

[t-hamano]

One approach would be to add that constant to the get_block_editor_settings() function, then you can access its value via wp.data.select('core/block-editor').getSettings(), but I'm not sure if this is the ideal approach.

[UmeraGhori]

Hi! I would like to work on this issue. I'll start by reproducing it locally.

[Mamaduka]

One approach would be to add that constant to the get_block_editor_settings() function, then you can access its value via wp.data.select('core/block-editor').getSettings(), but I'm not sure if this is the ideal approach.

Let's avoid that. It's an old practice. You can read more details in this post - https://make.wordpress.org/core/2024/09/12/gutenberg-development-practices-and-common-pitfalls/.

I think @TimothyBJacobs had a good suggestion in the linked issue - #13024 (comment). We should use the REST API to derive and handle post-type-related actions.

[UmeraGhori]

Thanks @Mamaduka for the guidance!

I checked the editor settings and found that disableTrash is already available there. I have updated the PostTrash component to check this setting and dynamically change the button label to "Delete permanently" when trash is disabled.

I've raised a PR with this fix.

[hbhalodia]

Hi @UmeraGhori, Can you pleaser check the comment here - #74265 (comment)

[hbhalodia]

Hi @t-hamano @Mamaduka, One approach as per the suggestion from @TimothyBJacobs, based on this comment would be something to implement like this,

Update this, https://github.com/WordPress/wordpress-develop/blob/f7d457d0a6b71fede4c34dfb8f8e764b29bc29ac/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php#L138-L144

To include the empty trash constant value, something like below,

'args'                => $this->get_delete_item_args(),

/**
 * Retrieves the delete item arguments.
 *
 * @return array Delete item arguments.
 */
public function get_delete_item_args() {
	$supports_trash = ( EMPTY_TRASH_DAYS > 0 );

	if ( 'attachment' === $this->post_type ) {
		$supports_trash = $supports_trash && MEDIA_TRASH;
	}

	/**
	 * Filters whether a post type supports trash.
	 *
	 * The dynamic portion of the hook name, `$this->post_type`, refers to the post type slug.
	 *
	 * @since 6.8.0
	 *
	 * @param bool $supports_trash Whether the post type supports trashing.
	 */
	$supports_trash = apply_filters( "rest_{$this->post_type}_trashable", $supports_trash, null );

	return array(
		'force' => array(
			'type'        => 'boolean',
			'default'     => false,
			'description' => __( 'Whether to bypass Trash and force deletion.' ),
			'required'    => ! $supports_trash,
		),
	);
}

Then, we should include this particular data to the items response so that it can be used in Gutenberg. Something like, https://github.com/WordPress/wordpress-develop/blob/f7d457d0a6b71fede4c34dfb8f8e764b29bc29ac/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php#L2045-L2056

if ( rest_is_field_included( 'supports_trash', $fields ) ) {
	$supports_trash = ( EMPTY_TRASH_DAYS > 0 );

	if ( 'attachment' === $post->post_type ) {
		$supports_trash = $supports_trash && MEDIA_TRASH;
	}

	/**
	 * Filters whether a post is trashable.
	 *
	 * @since 6.8.0
	 *
	 * @param bool    $supports_trash Whether the post type supports trashing.
	 * @param WP_Post $post           The Post object being considered for trashing support.
	 */
	$supports_trash = apply_filters( "rest_{$this->post_type}_trashable", $supports_trash, $post );

	$data['supports_trash'] = $supports_trash;
}

Based on this particular data, We can use const post = store.getCurrentPost(); and check this related supports_trash key and update the label as needed.

Also, onActionPerformed callback we should be adding a key delete to update the admin notice to provide the correct message to the user.

Something like below,

case 'move-to-trash':
	{
		document.location.href = addQueryArgs( 'edit.php', {
			trashed: 1,
			post_type: items[ 0 ].type,
			ids: items[ 0 ].id,
		} );
	}
	break;
case 'delete':
	{
		document.location.href = addQueryArgs( 'edit.php', {
			deleted: 1,
		} );
	}
	break;

Below is the screencast functionality for both trashed and delete,

Screen.Recording.2025-12-31.at.1.56.27.PM.mov

Here is the diff, that needs to be added on GB,

diff --git a/packages/edit-post/src/components/layout/index.js b/packages/edit-post/src/components/layout/index.js
index 88f5d51e33..1620312e6a 100644
--- a/packages/edit-post/src/components/layout/index.js
+++ b/packages/edit-post/src/components/layout/index.js
@@ -556,6 +556,13 @@ function Layout( {
 						} );
 					}
 					break;
+				case 'delete':
+					{
+						document.location.href = addQueryArgs( 'edit.php', {
+							deleted: 1,
+						} );
+					}
+					break;
 				case 'duplicate-post':
 					{
 						const newItem = items[ 0 ];
diff --git a/packages/editor/src/components/post-trash/index.js b/packages/editor/src/components/post-trash/index.js
index 2d3dd8bcb0..c69a76f0f0 100644
--- a/packages/editor/src/components/post-trash/index.js
+++ b/packages/editor/src/components/post-trash/index.js
@@ -23,15 +23,19 @@ import PostTrashCheck from './check';
  */
 export default function PostTrash( { onActionPerformed } ) {
 	const registry = useRegistry();
-	const { isNew, isDeleting, postId, title } = useSelect( ( select ) => {
-		const store = select( editorStore );
-		return {
-			isNew: store.isEditedPostNew(),
-			isDeleting: store.isDeletingPost(),
-			postId: store.getCurrentPostId(),
-			title: store.getCurrentPostAttribute( 'title' ),
-		};
-	}, [] );
+	const { isNew, isDeleting, postId, title, supportsTrash } =
+		useSelect( ( select ) => {
+			const store = select( editorStore );
+			const post = store.getCurrentPost();
+			return {
+				isNew: store.isEditedPostNew(),
+				isDeleting: store.isDeletingPost(),
+				postId: store.getCurrentPostId(),
+				title: store.getCurrentPostAttribute( 'title' ),
+				// Read supports_trash from the post object
+				supportsTrash: post.supports_trash !== false,
+			};
+		}, [] );
 	const { trashPost } = useDispatch( editorStore );
 	const [ showConfirmDialog, setShowConfirmDialog ] = useState( false );
 
@@ -42,13 +46,31 @@ export default function PostTrash( { onActionPerformed } ) {
 	const handleConfirm = async () => {
 		setShowConfirmDialog( false );
 		await trashPost();
-		const item = await registry
+		const actionType = supportsTrash ? 'move-to-trash' : 'delete';
+		const item = supportsTrash ? await registry
 			.resolveSelect( editorStore )
-			.getCurrentPost();
-		// After the post is trashed, we want to trigger the onActionPerformed callback, so the user is redirect
-		// to the post view depending on if the user is on post editor or site editor.
-		onActionPerformed?.( 'move-to-trash', [ item ] );
+			.getCurrentPost() : {};
+		// After the post is trashed/deleted, trigger the onActionPerformed callback
+		onActionPerformed?.( actionType, [ item ] );
 	};
+
+	const buttonText = supportsTrash
+		? __( 'Move to trash' )
+		: __( 'Delete permanently' );
+	const confirmButtonText = supportsTrash
+		? __( 'Move to trash' )
+		: __( 'Delete permanently' );
+	const confirmMessage = supportsTrash
+		? sprintf(
+				// translators: %s: The item's title.
+				__( 'Are you sure you want to move "%s" to the trash?' ),
+				title
+		  )
+		: sprintf(
+				// translators: %s: The item's title.
+				__( 'Are you sure you want to permanently delete "%s"?' ),
+				title
+		  );
 	return (
 		<PostTrashCheck>
 			<Button
@@ -62,20 +84,16 @@ export default function PostTrash( { onActionPerformed } ) {
 					isDeleting ? undefined : () => setShowConfirmDialog( true )
 				}
 			>
-				{ __( 'Move to trash' ) }
+				{ buttonText }
 			</Button>
 			<ConfirmDialog
 				isOpen={ showConfirmDialog }
 				onConfirm={ handleConfirm }
 				onCancel={ () => setShowConfirmDialog( false ) }
-				confirmButtonText={ __( 'Move to trash' ) }
+				confirmButtonText={ confirmButtonText }
 				size="small"
 			>
-				{ sprintf(
-					// translators: %s: The item's title.
-					__( 'Are you sure you want to move "%s" to the trash?' ),
-					title
-				) }
+				{ confirmMessage }
 			</ConfirmDialog>
 		</PostTrashCheck>
 	);

Ultimately, we need to update both wordpress core and Gutenberg code to make this work seamlessly.

Let me know your thoughts/suggesstions on the above approach?

Thank You,