Button: Migrate to width block support #74242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
aaronrobertshaw
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aaronrobertshaw
requested review from
andrewserong,
ramonjd,
talldan and
tellthemachines
30 tasks
|
Size Change: +169 B (+0.01%) Total Size: 2.59 MB
ℹ️ View Unchanged
|
SirLouen
previously requested changes
Dec 27, 2025
Member
SirLouen
left a comment
SirLouen
left a comment
There was a problem hiding this comment.
Test Report
Environment
- WordPress: 6.9
- PHP: 8.3.28-dev
- Server: PHP.wasm
- Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.51.0)
- Browser: Chrome 143.0.0.0
- OS: Windows 10/11
- Theme: Twenty Twenty-Five 1.4
- MU Plugins: None activated
- Plugins:
- Gutenberg 22.3.0
- Test Reports 1.2.1
Testing Steps
- Set to 500px the
widthfor the Button Global Style - Created a post with two buttons
- First button set to 100%
- Second button, left default
Actual Results
- ✅ PR is working
Additional Notes
⚠️ Added one improvement for the code.
Supplemental Artifacts
Backend
Frontend
Member
|
Working well in the frontend and editor for me. Checked global styles and theme.json as well. Backwards compat LGTM. I created some blocks in trunk, and the values are translated across to block supports: 
Is this the blocking change request? Agree it could be merged if there wasn't a good reason to split them, but I wouldn't consider it blocking. An easy follow up. I think the main blocker is the E2E fail - it seems related: Maybe it's because the settings tab is no longer there?
|
Contributor
Author
|
Appreciate the speedy reviews everyone 🙇
It definitely isn't but the blocking review was more just a slight difference in process etc. There's been some discussion with @SirLouen on other PRs e.g. #74189 (comment), so I think we're all a little more aligned on that now. That said, it was just an oversight when I was juggling a few things and that duplication definitely shouldn't be there. I'll get it cleaned up soon. Same for the failing e2e test. |
Contributor
Author
|
Quick update: I've removed the duplication but still have one last failing e2e locally that needs some further debugging. This might not be ready for further review until tomorrow. |
aaronrobertshaw
dismissed
SirLouen’s stale review
Feedback has been addressed and was non-blocking too
SirLouen
approved these changes
Dec 31, 2025
Member
|
Nice work. 🚀 |
Contributor
Author
|
Thank you for the reviews and testing here 🙇 I'm thinking I might hold off on merging this one for the moment. I'd like to possibly add default width presets for the Button block to match the old toggle group controls UX a little. This could just be a follow-up although I'll be offline for the next week or so and there's no time crunch on landing this. |
Contributor
Author
|
Looks like there's an edge case with creating presets for individual block types. Defining I'll have to dig into this one further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Migrates the Button block from using an ad-hoc
widthattribute to thedimensions.widthblock support.Why?
How?
widthattribute from block.jsondimensions.widthsupport with default controls enabledstyle.dimensions.widthformatTesting Instructions
UX Change
The width control changes from a toggle group with preset buttons (25/50/75/100%) to a dimension control that accepts any value. Themes can restore the preset-based UX by defining dimension sizes in theme.json.
Backward Compatibility
wp-block-button__width-25, etc.) are preserved for percentage valuesScreenshots or screencast
Screen.Recording.2025-12-27.at.12.16.10.pm.mp4