The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: swissspidy <[email protected]>
Co-authored-by: youknowriad <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Size Change: +28 B (0%)

Total Size: 1.77 MB

_{compressed-size-action}

Flaky tests detected in c07f8ce.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11086310859
📝 Reported issues:

• [Flaky Test] preserves content in the Custom HTML block #44672 in /test/e2e/specs/widgets/customizing-widgets.spec.js

The block should only be inserted once though, and on subsequent invocations it should just update the existing block.

Actually I'm not sure this is true. Isn't that different from the behavior of the inserter for blocks and patterns. Personally I expect a new block to be inserted each time I click on the media. Maybe we can save a cache of media elements per external image if needed but I'm not sure we should be changing how the inserter works.

Actually I'm not sure this is true. Isn't that different from the behavior of the inserter for blocks and patterns. Personally I expect a new block to be inserted each time I click on the media. Maybe we can save a cache of media elements per external image if needed but I'm not sure we should be changing how the inserter works.

No, this is not what this PR is about... Let me try to explain differently.

When using Media Experiments, the issue is this:

1. You click on the media once
2. The image file is fetched within onMediaInsert and then uploaded
3. In onMediaInsert, a onFileChange callback is added to insert a block.
4. The file is compressed, resized, etc. Every such step calls onFileChange
5. Because onFileChange is called numerous times, numerous blocks are inserted with the same image.

Of course, every time I click on the media, a new upload process should be triggered and a new block should be added. But then this block should only be added once per click, not numerous times.

Hope that makes sense. If not, just install Media Experiments and try it yourself. Happy to provide a screencast otherwise...

Yes, it does, thanks for explaining. Let me test this a bit.

In my tests in this PR, If I click again on an image after I had added it to the post, it doesn't insert it again. Am I missing something?

In my tests in this PR, If I click again on an image after I had added it to the post, it doesn't insert it again. Am I missing something?

Well then this unintentional, and probably is because of #65719 (comment) where I didn't reset the ref.

I just removed the ref now in favor of simply using getBlock. Now the insertion works as expected.

I guess it's very hard to trigger the "updateBlockAttributes" path at the moment. But this looks good to me and tests well.

Yeah right now it's only with the Media Experiments plugin, but eventually also with the client-side media processing experiment flag in Gutenberg (once that is merged)