Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a Quote from Paragraph Does Not Enable Save Draft Option #632

Open
akiashah opened this issue Mar 7, 2024 · 1 comment
Open
Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview [Status] Needs Reporter Feedback

Comments

@akiashah
Copy link

akiashah commented Mar 7, 2024

Describe the bug

After adding a paragraph and selecting a quote from it, the "Save Draft" option is enabled as expected. However, if the quote is subsequently removed from the paragraph, the "Save Draft" option does not get enabled again. This behavior suggests that the system does not recognize the removal of a quote as a change that warrants a draft save, potentially leading to loss of progress or confusion.

To generate this bug you need to click save draft after adding it to the paragraph.

To Reproduce
Steps to reproduce the behavior:

  1. Start editing or creating a new block.
  2. Add a paragraph of text.
  3. Select a portion of the text as a quote, triggering the "Save Draft" option to become active/enabled.
  4. Save the draft with the quote included.
  5. Edit the page again and remove the quote from the paragraph.
  6. Observe the behaviour of the "Save Draft" option. it will be not enabled again

Expected behavior
It should enable the save draft option while removing the quote from the paragraph.

Screenshots
Not needed.

Desktop (please complete the following information):

  • OS: MAC
  • Browser Chrome
  • Version 122.0.6261.94

Smartphone (please complete the following information):
NA

Additional context
Please create the quote paragraph first and save as draft after this only remove the quote you will find the issue.

@ryelle
Copy link
Contributor

ryelle commented Apr 18, 2024

I think you're running into some of the validation code that won't let you save an empty pattern. In your process, when you remove the quote in step 5, is there any other pattern content?

@ryelle ryelle added [Component] Pattern Creator Anything related to the pattern front end editor or preview [Status] Needs Reporter Feedback labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview [Status] Needs Reporter Feedback
Projects
None yet
Development

No branches or pull requests

2 participants