Skip to content

Security Plugin Score and Stats #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidperezgar opened this issue Apr 27, 2025 · 3 comments
Open

Security Plugin Score and Stats #920

davidperezgar opened this issue Apr 27, 2025 · 3 comments
Assignees
Labels
Needs Discussion Anything that needs a discussion/agreement

Comments

@davidperezgar
Copy link
Member

It would be nice a summary of stats for all checks made. I think that would be useful to show stats about checks done, errors and warning discovered. And we can think as a Health number of the plugin.

@davidperezgar davidperezgar added the Needs Discussion Anything that needs a discussion/agreement label May 4, 2025
@davidperezgar
Copy link
Member Author

I think that we can show:

  • Total lines in the plugin
  • Total Checks done
  • Errors Found (by severity more than 7 and less than 7)
  • Warnings Found
  • Total score

@swissspidy swissspidy marked this as a duplicate of #923 May 14, 2025
@davidperezgar davidperezgar changed the title Add Review Stats Security Plugin Score and Stats May 31, 2025
@davidperezgar
Copy link
Member Author

davidperezgar commented May 31, 2025

For the Score, I'm thinking: ERRORS x SEVERITY + ( WARNINGS x SEVERITY - CORRECTOR) and make a score between 0-100.

Or maybe, we could make a security score for each check.

@davidperezgar davidperezgar self-assigned this May 31, 2025
@frantorres
Copy link
Contributor

In terms of scoring, I think we need to change the approach to what is an error, what is a warning and the severity.

Right now the severity technically is more like "how sure we are that it's not a false positive", there are checks with the higher severity that do not really have impact on security.

Meanwhile, some of the main checks with impact on security (sanitization, escaping, nonces) have too many false positives to be able to consider them directly to create a score. In the internal script I'm creating new checks that only show issues it's sure about, but that information is partial and should be completed with the manual check.

I think we can create a score in terms of compatibility for example, as many checks in the compatibility area do not have false positives.

I'm not that sure sure on how to approach security. I guess with what we have now it will be more something informational than a score within a range on how security is for the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion Anything that needs a discussion/agreement
Projects
None yet
Development

No branches or pull requests

2 participants