Apply type casting and implicit defaults to ON DUPLICATE KEY UPDATE clause

Author: JanJakes

tests/WP_SQLite_Driver_Tests.php

@@ -10522,6 +10522,25 @@ public function testCastValuesOnInsertInNonStrictMode(): void {
 		$this->assertQuery( 'DROP TABLE t' );
 	}
 
+	public function testCastValuesOnDuplicateKeyUpdate(): void {
+		$this->assertQuery( 'CREATE TABLE t (value TEXT UNIQUE)' );
+		$this->assertQuery( "INSERT INTO t VALUES ('test')" );
+
+		// Ensure that type casting is applied to ON DUPLICATE KEY UPDATE clause.
+		$this->assertQuery( "INSERT INTO t VALUES ('test') ON DUPLICATE KEY UPDATE value = 0x61" );
+		$this->assertSame( 'a', $this->assertQuery( 'SELECT * FROM t' )[0]->value );
+	}
+
+	public function testCastValuesOnDuplicateKeyUpdateInNonStrictMode(): void {
+		$this->assertQuery( "SET SESSION sql_mode = ''" );
+		$this->assertQuery( 'CREATE TABLE t (value INT UNIQUE)' );
+		$this->assertQuery( "INSERT INTO t VALUES (123)" );
+
+		// Ensure that type casting is applied to ON DUPLICATE KEY UPDATE clause.
+		$this->assertQuery( "INSERT INTO t VALUES (123) ON DUPLICATE KEY UPDATE value = 'test'" );
+		$this->assertSame( '0', $this->assertQuery( 'SELECT * FROM t' )[0]->value );
+	}
+
 	public function testCastValuesOnUpdate(): void {
 		// INTEGER
 		$this->assertQuery( 'CREATE TABLE t (value INT)' );

wp-includes/sqlite-ast/class-wp-sqlite-driver.php

@@ -1531,6 +1531,13 @@ private function execute_insert_or_replace_statement( WP_Parser_Node $node ): vo
 				$table_ref  = $node->get_first_child_node( 'tableRef' );
 				$table_name = $this->unquote_sqlite_identifier( $this->translate( $table_ref ) );
 				$parts[]    = $this->translate_insert_or_replace_body( $table_name, $child );
+			} elseif ( $is_node && 'insertUpdateList' === $child->rule_name ) {
+				// Translate "ON DUPLICATE KEY UPDATE" to "ON CONFLICT DO UPDATE SET".
+				$parts[] = 'ON CONFLICT DO UPDATE SET ';
+				$parts[] = $this->translate_update_list(
+					$table_name,
+					$child->get_first_child_node( 'updateList' )
+				);
 			} else {
 				$parts[] = $this->translate( $child );
 			}
@@ -3241,12 +3248,6 @@ private function translate( $node ): ?string {
 					return null;
 				}
 				return $this->translate_sequence( $node->get_children() );
-			case 'insertUpdateList':
-				// Translate "ON DUPLICATE KEY UPDATE" to "ON CONFLICT DO UPDATE SET".
-				return sprintf(
-					'ON CONFLICT DO UPDATE SET %s',
-					$this->translate( $node->get_first_child_node( 'updateList' ) )
-				);
 			case 'simpleExpr':
 				return $this->translate_simple_expr( $node );
 			case 'predicateOperations':