Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer: Reduce gap between homepage CTA and footer #239

Closed
jasmussen opened this issue Mar 28, 2023 · 2 comments
Closed

Footer: Reduce gap between homepage CTA and footer #239

jasmussen opened this issue Mar 28, 2023 · 2 comments
Assignees
Labels
[Type] Enhancement New feature or request

Comments

@jasmussen
Copy link
Contributor

From #221:

(Mobile) Footer, in homepage: There’s a tall gap between CTA and footer links that can be a bit more conservative.

This issue is mainly visible on mobile:

Screenshot 2023-03-28 at 12 45 38

It seems like this could be about half that size on mobile, and may be accomplished with a clamp/vw based height value.

This is not an issue on other subpages at the moment.

@jasmussen jasmussen added the [Type] Enhancement New feature or request label Mar 28, 2023
@ryelle
Copy link
Contributor

ryelle commented Mar 28, 2023

There's a spacer in the content there, what if we just remove that? It shrinks the space a little on desktop too, but there's still a good amount of room:

Before After
before-desktop after-desktop
before-small after-small

@ryelle ryelle moved this to 📋 To do in WordPress.org Redesign Mar 28, 2023
@ryelle ryelle assigned ryelle and unassigned ryelle Mar 28, 2023
@ryelle ryelle added the [Status] Needs Design Feedback Feedback is needed on an existing or new component label Mar 28, 2023
@ryelle ryelle moved this from 📋 To do to 🛑 Pending discussion in WordPress.org Redesign Mar 28, 2023
@jasmussen
Copy link
Contributor Author

Looks good to me. As we sync later today we can bring it up once more.

@ryelle ryelle removed the [Status] Needs Design Feedback Feedback is needed on an existing or new component label Mar 30, 2023
@ryelle ryelle moved this from 🛑 Pending discussion to 📋 To do in WordPress.org Redesign Mar 30, 2023
@ryelle ryelle self-assigned this Apr 3, 2023
@ryelle ryelle moved this from 📋 To do to 🏗 In progress in WordPress.org Redesign Apr 3, 2023
@ryelle ryelle closed this as completed in b4caf5b Apr 3, 2023
@ryelle ryelle moved this from 🏗 In progress to ✅ Done in WordPress.org Redesign Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants