-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: Remove navigation highlights when on subpages/posts #370
Labels
Comments
jasmussen
changed the title
Navigation: Align and refine navigation highlights
Navigation: Remove navigation highlights when on subpages/posts
Mar 27, 2023
This was referenced Mar 27, 2023
Is there a determined outcome here? It sounds like this is still under discussion to me. |
From the discussion on our call yesterday, the outcome here is to stop highlighting when in the section — the top level item should only be highlighted when it's an exact match for the page. |
The "Forums" (and "Learn") section should not be highlighted when on the search page. See WordPress/wporg-main-2022#216 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From WordPress/wporg-main-2022#221
As an example, in the main news section, the item is highlighted:
When in subpages or permalinks, it remains highlighted (parent):
This is similar in About and About subpages:
While the ability to highlight the parent and ancestor of a page or post is a pattern we're leveraging here, it hasn't materially aided wayfinding, and has caused a few issues on its own.
Should we hide this highlight? It seems especially an issue on mobile:
The text was updated successfully, but these errors were encountered: