Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Remove navigation highlights when on subpages/posts #370

Closed
jasmussen opened this issue Mar 27, 2023 · 3 comments · Fixed by #384
Closed

Navigation: Remove navigation highlights when on subpages/posts #370

jasmussen opened this issue Mar 27, 2023 · 3 comments · Fixed by #384
Assignees

Comments

@jasmussen
Copy link
Collaborator

From WordPress/wporg-main-2022#221

When in subpages, the top nav highlights the main page. Worth removing to not mislead the user with wayfinding.

As an example, in the main news section, the item is highlighted:

Screenshot 2023-03-27 at 12 08 24

When in subpages or permalinks, it remains highlighted (parent):

Screenshot 2023-03-27 at 12 08 35

This is similar in About and About subpages:

Screenshot 2023-03-27 at 12 09 42

Screenshot 2023-03-27 at 12 09 53

While the ability to highlight the parent and ancestor of a page or post is a pattern we're leveraging here, it hasn't materially aided wayfinding, and has caused a few issues on its own.

Should we hide this highlight? It seems especially an issue on mobile:

Screenshot 2023-03-27 at 12 36 02

Screenshot 2023-03-27 at 12 40 54

@jasmussen jasmussen added the [Type] Enhancement New feature or request label Mar 27, 2023
@jasmussen jasmussen changed the title Navigation: Align and refine navigation highlights Navigation: Remove navigation highlights when on subpages/posts Mar 27, 2023
@ryelle
Copy link
Contributor

ryelle commented Mar 28, 2023

Is there a determined outcome here? It sounds like this is still under discussion to me.

@ryelle ryelle transferred this issue from WordPress/wporg-main-2022 Mar 28, 2023
@ryelle ryelle moved this to 📋 To do in WordPress.org Redesign Mar 28, 2023
@ryelle
Copy link
Contributor

ryelle commented Mar 30, 2023

From the discussion on our call yesterday, the outcome here is to stop highlighting when in the section — the top level item should only be highlighted when it's an exact match for the page.

@ryelle
Copy link
Contributor

ryelle commented Apr 4, 2023

The "Forums" (and "Learn") section should not be highlighted when on the search page. See WordPress/wporg-main-2022#216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants