Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noreferrer from links in Site Link block #250

Closed
ndiego opened this issue Oct 16, 2023 · 0 comments · Fixed by #251
Closed

Remove noreferrer from links in Site Link block #250

ndiego opened this issue Oct 16, 2023 · 0 comments · Fixed by #251
Assignees
Labels
[Component] Blocks/Editor Custom blocks, block variations, or editor customization
Milestone

Comments

@ndiego
Copy link
Member

ndiego commented Oct 16, 2023

Per the feedback in #234, there really shouldn't be noreferrer on the site links in the Showcase. It's probably a good thing for receiving sites to see wp.org referrals.

The noreferrer needs to be removed here:

'<p %1$s><a href="%2$s" target="_blank" rel="noopener noreferrer">%3$s</a></p>',

@ndiego ndiego added this to the Launch milestone Oct 16, 2023
@ndiego ndiego added the [Component] Blocks/Editor Custom blocks, block variations, or editor customization label Oct 16, 2023
@ndiego ndiego self-assigned this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Blocks/Editor Custom blocks, block variations, or editor customization
Development

Successfully merging a pull request may close this issue.

1 participant