Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New system for game patches #218

Open
PiKeyAr opened this issue Sep 30, 2024 · 1 comment
Open

New system for game patches #218

PiKeyAr opened this issue Sep 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@PiKeyAr
Copy link
Member

PiKeyAr commented Sep 30, 2024

With the current game patches (such as "HRTF Sound", "Keep Camera Settings" etc. in SADX), each patch is stored in the profile JSON as a separate bool value, which requires handling each patch separately. Instead, I suggest storing a list of enabled patches as strings. This reduces the amount of code required to add new patches, especially on the Loader's side.

The new system on the Loader's side is ready to use, the section is called EnabledGamePatches. Example:

  "EnabledGamePatches": [
    "HRTFSound",
    "KeepCamSettings",
    "FixVertexColorRendering",
    "MaterialColorFix",
    "NodeLimit",
    "FOVFix"
  ]
@PiKeyAr PiKeyAr added the enhancement New feature or request label Sep 30, 2024
@PiKeyAr
Copy link
Member Author

PiKeyAr commented Sep 30, 2024

Another relevant thing I thought I should mention: we need to distinguish between game patches and patch-type codes, since both are called "patches". I suggest using "game patches" and "patch-type codes" to avoid confusion. I'll take care of this on the Loader's side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant