Skip to content

Commit 10acb9a

Browse files
committed
Change config parameter name to comply with what was discussed as part of FLIP-461
1 parent e12edd5 commit 10acb9a

File tree

6 files changed

+8
-9
lines changed

6 files changed

+8
-9
lines changed

docs/layouts/shortcodes/generated/all_jobmanager_section.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
</thead>
1010
<tbody>
1111
<tr>
12-
<td><h5>jobmanager.adaptive-scheduler.max-delay-for-rescale-trigger</h5></td>
12+
<td><h5>jobmanager.adaptive-scheduler.max-delay-for-scale-trigger</h5></td>
1313
<td style="word-wrap: break-word;">(none)</td>
1414
<td>Duration</td>
1515
<td>The maximum time the JobManager will wait with evaluating previously observed events for rescaling (default: 0ms if checkpointing is disabled and %dx of the checkpointing interval if checkpointing is enabled).</td>

docs/layouts/shortcodes/generated/expert_scheduling_section.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
<td>The size of the write buffer of JobEventStore. The content will be flushed to external file system once the buffer is full</td>
8888
</tr>
8989
<tr>
90-
<td><h5>jobmanager.adaptive-scheduler.max-delay-for-rescale-trigger</h5></td>
90+
<td><h5>jobmanager.adaptive-scheduler.max-delay-for-scale-trigger</h5></td>
9191
<td style="word-wrap: break-word;">(none)</td>
9292
<td>Duration</td>
9393
<td>The maximum time the JobManager will wait with evaluating previously observed events for rescaling (default: 0ms if checkpointing is disabled and %dx of the checkpointing interval if checkpointing is enabled).</td>

docs/layouts/shortcodes/generated/job_manager_configuration.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
</thead>
1010
<tbody>
1111
<tr>
12-
<td><h5>jobmanager.adaptive-scheduler.max-delay-for-rescale-trigger</h5></td>
12+
<td><h5>jobmanager.adaptive-scheduler.max-delay-for-scale-trigger</h5></td>
1313
<td style="word-wrap: break-word;">(none)</td>
1414
<td>Duration</td>
1515
<td>The maximum time the JobManager will wait with evaluating previously observed events for rescaling (default: 0ms if checkpointing is disabled and %dx of the checkpointing interval if checkpointing is enabled).</td>

flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -578,8 +578,8 @@ public InlineElement getDescription() {
578578
Documentation.Sections.EXPERT_SCHEDULING,
579579
Documentation.Sections.ALL_JOB_MANAGER
580580
})
581-
public static final ConfigOption<Duration> MAXIMUM_DELAY_FOR_RESCALE_TRIGGER =
582-
key("jobmanager.adaptive-scheduler.max-delay-for-rescale-trigger")
581+
public static final ConfigOption<Duration> MAXIMUM_DELAY_FOR_SCALE_TRIGGER =
582+
key("jobmanager.adaptive-scheduler.max-delay-for-scale-trigger")
583583
.durationType()
584584
.noDefaultValue()
585585
.withDescription(

flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@
145145
import java.util.concurrent.TimeUnit;
146146
import java.util.function.Function;
147147

148-
import static org.apache.flink.configuration.JobManagerOptions.MAXIMUM_DELAY_FOR_RESCALE_TRIGGER;
148+
import static org.apache.flink.configuration.JobManagerOptions.MAXIMUM_DELAY_FOR_SCALE_TRIGGER;
149149
import static org.apache.flink.configuration.JobManagerOptions.MIN_PARALLELISM_INCREASE;
150150
import static org.apache.flink.runtime.executiongraph.ExecutionGraphUtils.isAnyOutputBlocking;
151151

@@ -245,8 +245,7 @@ public static Settings of(
245245
scalingIntervalMax,
246246
configuration.get(MIN_PARALLELISM_INCREASE),
247247
configuration.get(
248-
MAXIMUM_DELAY_FOR_RESCALE_TRIGGER,
249-
maximumDelayForRescaleTriggerDefault));
248+
MAXIMUM_DELAY_FOR_SCALE_TRIGGER, maximumDelayForRescaleTriggerDefault));
250249
}
251250

252251
private final SchedulerExecutionMode executionMode;

flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/DefaultRescaleManagerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ void testProperConfiguration() {
4848
configuration.set(JobManagerOptions.SCHEDULER_SCALING_INTERVAL_MIN, scalingIntervalMin);
4949
configuration.set(JobManagerOptions.SCHEDULER_SCALING_INTERVAL_MAX, scalingIntervalMax);
5050
configuration.set(
51-
JobManagerOptions.MAXIMUM_DELAY_FOR_RESCALE_TRIGGER, maximumDelayForRescaleTrigger);
51+
JobManagerOptions.MAXIMUM_DELAY_FOR_SCALE_TRIGGER, maximumDelayForRescaleTrigger);
5252

5353
final DefaultRescaleManager testInstance =
5454
DefaultRescaleManager.Factory.fromSettings(

0 commit comments

Comments
 (0)