[FLINK-36207] Testing that the @public API change still is caught

Author: XComp

flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java

@@ -71,7 +71,7 @@ public String toString() {
         return versionStr;
     }
 
-    public boolean isNewerVersionThan(FlinkVersion otherVersion) {
+    public boolean isNewerVersionThanChangedName(FlinkVersion otherVersion) {
         return this.ordinal() > otherVersion.ordinal();
     }
 

flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerUpgradeTestBase.java

@@ -528,7 +528,7 @@ private static <T> void writeSerializerSnapshot(
             DataOutputView out, TypeSerializer<T> serializer, FlinkVersion flinkVersion)
             throws IOException {
 
-        if (flinkVersion.isNewerVersionThan(FlinkVersion.v1_6)) {
+        if (flinkVersion.isNewerVersionThanChangedName(FlinkVersion.v1_6)) {
             writeSerializerSnapshotCurrentFormat(out, serializer);
         } else {
             throw new UnsupportedOperationException(
@@ -547,7 +547,7 @@ private static <T> TypeSerializerSnapshot<T> readSerializerSnapshot(
             DataInputView in, FlinkVersion flinkVersion) throws IOException {
 
         ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
-        checkState(flinkVersion.isNewerVersionThan(FlinkVersion.v1_6));
+        checkState(flinkVersion.isNewerVersionThanChangedName(FlinkVersion.v1_6));
         return readSerializerSnapshotCurrentFormat(in, classLoader);
     }
 

flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/RowSerializerUpgradeTest.java

@@ -126,7 +126,7 @@ public Condition<Row> testDataCondition() {
         @Override
         public Condition<TypeSerializerSchemaCompatibility<Row>> schemaCompatibilityCondition(
                 FlinkVersion version) {
-            if (version.isNewerVersionThan(FlinkVersion.v1_10)) {
+            if (version.isNewerVersionThanChangedName(FlinkVersion.v1_10)) {
                 return TypeSerializerConditions.isCompatibleAsIs();
             }
             return TypeSerializerConditions.isCompatibleAfterMigration();

flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/NFASerializerUpgradeTest.java

@@ -367,7 +367,7 @@ public Condition<NFAState> testDataCondition() {
         @Override
         public Condition<TypeSerializerSchemaCompatibility<NFAState>> schemaCompatibilityCondition(
                 FlinkVersion version) {
-            if (version.isNewerVersionThan(FlinkVersion.v1_15)) {
+            if (version.isNewerVersionThanChangedName(FlinkVersion.v1_15)) {
                 return TypeSerializerConditions.isCompatibleAsIs();
             }
             return TypeSerializerConditions.isCompatibleAfterMigration();

flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkStateSerializerUpgradeTest.java

@@ -122,7 +122,7 @@ public Condition<TwoPhaseCommitSinkFunction.State<Integer, String>> testDataCond
                         TypeSerializerSchemaCompatibility<
                                 TwoPhaseCommitSinkFunction.State<Integer, String>>>
                 schemaCompatibilityCondition(FlinkVersion version) {
-            if (version.isNewerVersionThan(FlinkVersion.v1_13)) {
+            if (version.isNewerVersionThanChangedName(FlinkVersion.v1_13)) {
                 return TypeSerializerConditions.isCompatibleAsIs();
             } else {
                 return TypeSerializerConditions.isCompatibleAfterMigration();

flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializerUpgradeTest.java

@@ -112,7 +112,7 @@ public Condition<LinkedList<Long>> testDataCondition() {
         @Override
         public Condition<TypeSerializerSchemaCompatibility<LinkedList<Long>>>
                 schemaCompatibilityCondition(FlinkVersion version) {
-            if (version.isNewerVersionThan(FlinkVersion.v1_13)) {
+            if (version.isNewerVersionThanChangedName(FlinkVersion.v1_13)) {
                 return TypeSerializerConditions.isCompatibleAsIs();
             } else {
                 return TypeSerializerConditions.isCompatibleAfterMigration();