Skip to content

Commit 2e853ce

Browse files
committed
[review] Moves JavaDoc into interface and adds @OverRide annotation
1 parent 0cdec92 commit 2e853ce

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,16 @@ PendingCheckpointStats reportPendingCheckpoint(
106106

107107
void reportFailedCheckpoint(FailedCheckpointStats failed);
108108

109+
/**
110+
* Callback when a checkpoint failure without in progress checkpoint. For example, it should be
111+
* callback when triggering checkpoint failure before creating PendingCheckpoint.
112+
*/
109113
void reportFailedCheckpointsWithoutInProgress();
110114

115+
/**
116+
* Creates a new snapshot of the available stats.
117+
*
118+
* @return The latest statistics snapshot.
119+
*/
111120
CheckpointStatsSnapshot createSnapshot();
112121
}

flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTracker.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,7 @@ public DefaultCheckpointStatsTracker(
111111
registerMetrics(metricGroup);
112112
}
113113

114-
/**
115-
* Creates a new snapshot of the available stats.
116-
*
117-
* @return The latest statistics snapshot.
118-
*/
114+
@Override
119115
public CheckpointStatsSnapshot createSnapshot() {
120116
CheckpointStatsSnapshot snapshot = latestSnapshot;
121117

@@ -253,10 +249,7 @@ private void logCheckpointStatistics(AbstractCheckpointStats checkpointStats) {
253249
}
254250
}
255251

256-
/**
257-
* Callback when a checkpoint failure without in progress checkpoint. For example, it should be
258-
* callback when triggering checkpoint failure before creating PendingCheckpoint.
259-
*/
252+
@Override
260253
public void reportFailedCheckpointsWithoutInProgress() {
261254
statsReadWriteLock.lock();
262255
try {

0 commit comments

Comments
 (0)