Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dandelion-1.1.1 单元测试编译错误 #29

Open
STORM-S314 opened this issue Oct 12, 2024 · 1 comment
Open

dandelion-1.1.1 单元测试编译错误 #29

STORM-S314 opened this issue Oct 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@STORM-S314
Copy link

报错如下:

dandelion-1.1.1/test/geometry_tests.cpp:30:17: error: unused variable 'threshold' [-Werror,-Wunused-const-variable]
constexpr float threshold = 1e-3f;
^
1 error generated.
make[2]: *** [CMakeFiles/test.dir/geometry_tests.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/test.dir/all] Error 2

test项目下的 geometry_tests.cpp中的threshold变量没有被使用,所以会抛出编译错误,建议在threshold_squ中使用threshold乘积。

@STORM-S314 STORM-S314 added the bug Something isn't working label Oct 12, 2024
@greyishsong
Copy link
Member

没问题,你直接开一个 PR 提交就可以,之后记得反向移植回 dev channel 。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants