Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for .fb2 format #134

Open
sr79368142 opened this issue Oct 19, 2024 · 2 comments
Open

[Feature Request] Support for .fb2 format #134

sr79368142 opened this issue Oct 19, 2024 · 2 comments

Comments

@sr79368142
Copy link

Dear Xanashi, I was going to use icaros to unify file thumbnails, but it doesn't seem to support fb2 thumbnail display?
I enabled fb2 thumbnail support inside icaros but it is not working, after adding the fb2 format I cleaned up the thumbnails and restarted the system but no images show up on the fb2 novel files.
I had to compromise one step and reinstall darkthumbs, but if I don't remove fb2 inside icaros, it will overwrite the DarkThumbs settings. Only by removing it will darkthumbs work.
I hope you can check the reason for this, if it's a bug I hope you can fix it in the next update, if it's unsupported I hope you can add this feature to a future project!
Thank you so much for developing such a great app, kudos to you!

@Xanashi
Copy link
Owner

Xanashi commented Oct 20, 2024

Hi sr79368142,
Yeah, fb2 is currently not supported by Icaros. If you can send me a few sample files, I could look into the format and
see what it would require of me to add support for it.

I would definitely recommend removing any filetype that is not supported by Icaros, from the 'Thumbnail filetypes' list in IcarosConfig, if they've been added manually.
However just having the filetype enabled in Icaros shouldn't block other shell extensions from overwriting the registration,
and become the primary handler of that filetype.

I've always intended for Icaros to work perfectly well with other shell extensions and third party Explorers etc.,
so if there is a conflict with another software I'm always open to fix what I can on my end.
In this case though, it sounds like DarkThumbs may avoid overwriting existing thumbnail providers, and only registers
when any existing thumbnail provider has been unregistered for a specific filetype?

Thank you for the kind words!

@sr79368142
Copy link
Author

Dear Xanashi , I tried to find a solution from the Internet before I reported this bug, and I read about the .fb2 format, which is a plain text ebook format using XML syntax, and the images embedded in the book are converted to base64 encoding and stored at the end of the file. .fb2 has an open source editor on GitHub: https: //github.com/sensboston/fictionbookeditor
Also, I posted a discussion about this last night in a software tutorial community, where a user is experiencing the same bug; he uses a middle-mouse button launcher called Quicker, which comes with a clipboard plugin, and in the last couple of days the thumbnails of the images above the clipboard plugin are not displaying. This is Quicker's official website: https: //getquicker.net/
I guessed if he had installed and updated Icaros, he replied yes, I suggested him to clean up the image format extension inside icaros and clear the thumbnail cache, reboot the system and then see if the thumbnails will be restored. He did as I said, and when that was done, the image thumbnails on his clipboard plugin were successfully restored.
This piqued my curiosity and I tried to reinstall icaros, and while setting up the display formats for icaros, I realized that the new version has preset image types. If these image formats are added to the display bar, they may not show up as thumbnails in Explorer or other file managers.
I'm not sure what other apps it conflicts with; I use XviewMP as my image viewer by default, and I'm not sure if its decoder is written by the developer or calls the system.
I went to DarkThumb next, and DarkThumb will explain in detail what codecs it uses in the update, and some of its formatting calls the system's own WIC component library, so maybe there's a conflict with this component library when it's called? You can refer to the update instructions here: https: //github.com/fire-eggs/DarkThumbs
I apologize for not being a native English speaker and not having the programming knowledge to be able to provide more details about the bugs you need! Finally, I can provide you with a copy of my personal edited .fb2 format novel as a reference, maybe it can provide you with a little bit of inspiration for your solution idea?
武林旧事录之花落春归.zip

@Xanashi Xanashi changed the title Would like to support thumbnail display in .fb2 format! [Feature Request] Support for .fb2 format Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants