-
Couldn't load subscription status.
- Fork 233
Rotation based equalization #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c95387d to
66d6661
Compare
5942658 to
7f26f10
Compare
|
Current limitations:
|
ecf7b4f to
cb691c4
Compare
cb691c4 to
5850118
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some basic tests for the LLM entry-point as well? Both for RMSNorm & rotations?
|
Other than the hadamard matrix instantiation issue, this LGTM (once above changes are applied). |
Reason for this PR
Implement rotation based equalization for weights and activation.
Highlights:
Changes Made in this PR
The graph based region algorithm has been extended and generalized to support different set of supported layers based on what type of equalization is applied.
Important considerations:
Testing Summary
Added one test that checks:
Risk Highlight
Checklist
devbranch.