- 
                Notifications
    You must be signed in to change notification settings 
- Fork 233
Rotation based equalization #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    c95387d    to
    66d6661      
    Compare
  
    
              
                    Giuseppe5
  
              
              commented
              
                  
                    Oct 20, 2024 
                  
              
              
            
            
              
                    Giuseppe5
  
              
              commented
              
                  
                    Oct 20, 2024 
                  
              
              
            
            
              
                    Giuseppe5
  
              
              commented
              
                  
                    Oct 20, 2024 
                  
              
              
            
            
              
                    Giuseppe5
  
              
              commented
              
                  
                    Oct 20, 2024 
                  
              
              
            
            
5942658    to
    7f26f10      
    Compare
  
    | Current limitations: 
 | 
ecf7b4f    to
    cb691c4      
    Compare
  
    cb691c4    to
    5850118      
    Compare
  
    
              
                    nickfraser
  
              
              requested changes
              
                  
                    Nov 7, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some basic tests for the LLM entry-point as well? Both for RMSNorm & rotations?
| Other than the hadamard matrix instantiation issue, this LGTM (once above changes are applied). | 
              
                    Giuseppe5
  
              
              commented
              
                  
                    Nov 7, 2024 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Reason for this PR
Implement rotation based equalization for weights and activation.
Highlights:
Changes Made in this PR
The graph based region algorithm has been extended and generalized to support different set of supported layers based on what type of equalization is applied.
Important considerations:
Testing Summary
Added one test that checks:
Risk Highlight
Checklist
devbranch.