Remove unused NonContiguousIterableTypesT typedef. It is easy for this typedef to get out of sync with other code

Signed-off-by: Rickert, Jonas <[email protected]>

Author: jorickert

src/Dialect/ONNX/ElementsAttr/DisposableElementsAttr.hpp

@@ -186,13 +186,6 @@ class DisposableElementsAttr
   // to copy out data in bulk with getArray/WideNums() and readArray/WideNums().
   //===--------------------------------------------------------------------===//
 
-  // All the iterable types are listed as NonContiguous here as no type
-  // is guaranteed to be represented contiguously in the underlying buffer
-  // because of strides and the possibility that bufferBType != btype.
-  using NonContiguousIterableTypesT =
-      std::tuple<Attribute, IntegerAttr, FloatAttr, APInt, APFloat, WideNum,
-          bool, int8_t, uint8_t, int16_t, int8_t, int32_t, uint32_t, int64_t,
-          uint64_t, onnx_mlir::float_16, onnx_mlir::bfloat_16, float, double>;
 
   // An underlying iota_range sequence iterator returns size_t flat indices
   // which are mapped to elements of type X by a function<X(size_t)>.
@@ -206,7 +199,7 @@ class DisposableElementsAttr
   using iterator_range = llvm::iterator_range<iterator<X>>;
 
   // This implementation enables the value_begin() and getValues() methods
-  // from the ElementsAttr interface, for the NonContiguousIterableTypesT types.
+  // from the ElementsAttr interface
   template <typename X>
   FailureOr<iterator<X>> try_value_begin_impl(OverloadToken<X>) const;
 

src/Dialect/ONNX/ElementsAttr/DisposableElementsAttr.hpp.inc

@@ -5,14 +5,13 @@
 //===----------------------------------------------------------------------===//
 
 namespace detail {
-// True for the types T in DisposableElementsAttr::NonContiguousIterableTypesT.
+
 template <typename T>
 constexpr bool isIterableType =
     llvm::is_one_of<T, Attribute, IntegerAttr, FloatAttr, APInt, APFloat,
         onnx_mlir::WideNum>::value ||
     onnx_mlir::CppTypeTrait<T>::isIntOrFloat;
 
-// Supports all the types T in NonContiguousIterableTypesT.
 template <typename T>
 T getNumber(Type elementType, onnx_mlir::BType tag, onnx_mlir::WideNum n) {
   static_assert(isIterableType<T>);