feat: Check app version in plugin loading (#537)

Make sure the app version is at least the required version specified in
the plugin's metadata: dependencies/app
Part of #532

Author: zehnm

sources/launcher.cpp

@@ -22,6 +22,7 @@
 
 #include "launcher.h"
 
+#include <QCoreApplication>
 #include <QPluginLoader>
 #include <QVersionNumber>
 
@@ -43,10 +44,12 @@ QObject *Launcher::loadPlugin(const QString &path, const QString &pluginName) {
     QPluginLoader pluginLoader(pluginPath, this);
 
     QJsonObject metaData = pluginLoader.metaData()["MetaData"].toObject();
-    QString     pluginIntgLibVersion = metaData["dependencies"].toObject()["integrations.library"].toString();
+    QJsonObject dependencies = metaData["dependencies"].toObject();
+    QString     pluginIntgLibVersion = dependencies["integrations.library"].toString();
+    QString     requiredMinAppVersion = dependencies["app"].toString();
 
     qCInfo(lcPlugin) << "Loading plugin:" << pluginPath << "version:" << metaData["version"].toString()
-                     << "intg.lib:" << pluginIntgLibVersion;
+                     << "intg.lib:" << pluginIntgLibVersion << "min app version:" << requiredMinAppVersion;
 
     if (pluginIntgLibVersion.isEmpty()) {
         Notifications::getInstance()->add(true, tr("Incompatible plugin %1: metadata missing").arg(pluginName));
@@ -58,6 +61,12 @@ QObject *Launcher::loadPlugin(const QString &path, const QString &pluginName) {
         return nullptr;
     }
 
+    if (!isCompatibleAppVersion(requiredMinAppVersion)) {
+        Notifications::getInstance()->add(
+            true, tr("Plugin %1 requires app version %2 or higher").arg(pluginName, requiredMinAppVersion));
+        return nullptr;
+    }
+
     QObject *plugin = pluginLoader.instance();
     if (!plugin) {
         qCCritical(lcPlugin) << "Failed to load plugin:" << pluginPath << pluginLoader.errorString();
@@ -98,6 +107,13 @@ bool Launcher::isCompatibleIntgLibVersion(const QString &pluginIntgLibVersion) {
            intgVersionPlugin.minorVersion() == intgVersion.minorVersion();
 }
 
+bool Launcher::isCompatibleAppVersion(const QString &requiredMinAppVersion) {
+    QVersionNumber appVersion = QVersionNumber::fromString(cleanVersionString(QCoreApplication::applicationVersion()));
+    QVersionNumber reqMinVersion = QVersionNumber::fromString(cleanVersionString(requiredMinAppVersion));
+
+    return QVersionNumber::compare(appVersion, reqMinVersion) >= 0;
+}
+
 QString Launcher::cleanVersionString(const QString &version) {
     if (version.startsWith('v')) {
         return version.mid(1);

sources/launcher.h

@@ -38,6 +38,11 @@ class Launcher : public QObject {
      */
     bool isCompatibleIntgLibVersion(const QString &pluginIntgLibVersion);
 
+    /**
+     * @brief Returns true if the required minium app version is fulfilled
+     */
+    bool isCompatibleAppVersion(const QString &requiredMinAppVersion);
+
  private:
     QString cleanVersionString(const QString &version);
 

translations/en_US.ts

@@ -608,17 +608,22 @@ to set up YIO remote</source>
 <context>
     <name>Launcher</name>
     <message>
-        <location filename="../sources/launcher.cpp" line="52"/>
+        <location filename="../sources/launcher.cpp" line="55"/>
         <source>Incompatible plugin %1: metadata missing</source>
         <translation type="unfinished"></translation>
     </message>
     <message>
-        <location filename="../sources/launcher.cpp" line="57"/>
+        <location filename="../sources/launcher.cpp" line="60"/>
         <source>Incompatible plugin %1: integration lib mismatch</source>
         <translation type="unfinished"></translation>
     </message>
     <message>
-        <location filename="../sources/launcher.cpp" line="64"/>
+        <location filename="../sources/launcher.cpp" line="66"/>
+        <source>Plugin %1 requires app version %2 or higher</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="../sources/launcher.cpp" line="73"/>
         <source>Failed to load %1</source>
         <translation type="unfinished"></translation>
     </message>