Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some themes fail with new bootstrap ("siteStyle": 3) #6725

Open
rpaal10 opened this issue Jan 22, 2025 · 5 comments
Open

Some themes fail with new bootstrap ("siteStyle": 3) #6725

rpaal10 opened this issue Jan 22, 2025 · 5 comments

Comments

@rpaal10
Copy link

rpaal10 commented Jan 22, 2025

Describe the bug
Some themes fail with new bootstrap ("siteStyle": 3)

To Reproduce
Steps to reproduce the behavior:
Try different themes, using: "siteStyle": 3

Screenshots
With the cyborg, Darkly, and more themes, the My devices and My accoount titles disappears.

Image

Image

corrects:

Image

Image

This happens with different themes.
Some themes make different parts of the interface disappear

Server Software (please complete the following information):

  • OS: [Debian]
  • Virtualization: [Vmware]
  • Network: [WAN]
  • Version: [1.1.38]

Your config.json file

{
  "$schema": "https://raw.githubusercontent.com/Ylianst/MeshCentral/master/meshcentral-config-schema.json",
  "__comment1__": "This is a simple configuration file, all values and sections that start with underscore (_) are ignored. Edit a section and remove the _ in front of the name. Refer to the user's guide for details.",
  "__comment2__": "See node_modules/meshcentral/sample-config-advanced.json for a more advanced example.",
  "settings": {
    "cert": "SERVER.SERVER",
    "_WANonly": true,
    "_LANonly": true,
    "sessionKey": "XXXX",
    "Compression": true,
    "WsCompression": true,
    "AgentWsCompression": true,
    "webRTC": true,
    "AgentPong": 60,
    "DesktopMultiplex": true,
    "AllowHighQualityDesktop": false,
    "port": 443,
    "aliasPort": 443,
    "redirPort": 80,
    "_redirAliasPort": 80,
    "maxInvalidLogin": {
      "time": 3,
      "count": 5,
      "coolofftime": 1
    },
    "plugins": {
      "enabled": true
    }
  },
  "domains": {
    "": {
      "title": "MeshCentral",
      "_title1": "xx",
      "title2": "xx",
      "minify": false,
      "UserSessionIdleTimeout": 30,
      "skipChallengeVerification": true,
      "_titlePicture": "title.png",
      "loginPicture": "title.png",
      "siteStyle": 3,
      "welcomeText": "<b>This server will be shutting down on Auguest 12th 2023.</b>",
      "_welcomePicture": "mainwelcome.jpg",
      "Footer": "<b>2This server will be shutting down on Auguest 12th 2023.</b>",
      "loginfooter": "This is a private server.",
      "agenttag": {
        "ServerName": 0,
        "ServerDesc": 0,
        "ServerTags": 1
      },
      "_hide": 4,
      "_newAccounts": true,
      "_newAccountsCaptcha": true,
      "_userNameIsEmail": true,
      "_nightMode": 1,
      "_hide": 5,
      "passwordRequirements": {
        "banCommonPasswords": true
      }
    }
  },
  "_letsencrypt": {
    "__comment__": "Requires NodeJS 8.x or better, Go to https://letsdebug.net/ first before trying Let's Encrypt.",
    "email": "[email protected]",
    "names": "myserver.mydomain.com",
    "skipChallengeVerification": true,
    "production": false
  }
}
@rpaal10 rpaal10 added the bug label Jan 22, 2025
@si458
Copy link
Collaborator

si458 commented Jan 22, 2025

Have u tried switching your browser itself into dark mode?
I remember the darkly theme looked weird, but switch ur browser into dark mode and wow it looked good!

@rpaal10
Copy link
Author

rpaal10 commented Jan 23, 2025

@si458
Thanks! With dark mode, its work fine.

Still, shouldn't it work responsively with any theme?

@si458
Copy link
Collaborator

si458 commented Jan 23, 2025

@rpaal10 yes and no

If u check out the themes here, https://bootswatch.com/

And use their toggle theme for their light/dark mode

For cyborg, for example, their light mode actually uses dark backgrounds everywhere!

So, it would mean we need to fully customise the themes again to fix things like the background colour everywhere, so it would be a big job

What we could do is add better descriptions

E.g. Cyborg (best for use with dark mode)

@rpaal10
Copy link
Author

rpaal10 commented Jan 23, 2025

@si458
Thanks for the info.
I was just saying this in case it was an uncontrolled error.

@si458
Copy link
Collaborator

si458 commented Jan 26, 2025

@Ndaboom @kambereBr can you look into these for me at all?
if we use say Cyborg it looks weird in light mode,
but switch to dark mode and WOW its brilliant!
i think we might need to edit the theme style sheets so it changes the background colour to BLACK for these type of themes
not sure HOW EASY its going to be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants