Refactor group removal to use list-based subprocess call (#2264)

RinZ27 · web-flow · commit 568a7b8edad7 · 2026-02-04T22:03:09.000+01:00
diff --git a/src/user.py b/src/user.py
@@ -1124,7 +1124,7 @@ def user_group_create(
                 m18n.n("group_already_exist_on_system_but_removing_it", group=groupname)
             )
             subprocess.check_call(
-                f"sed --in-place '/^{groupname}:/d' /etc/group", shell=True
+                ["sed", "--in-place", f"/^{groupname}:/d", "/etc/group"]
             )
         else:
             raise YunohostValidationError(

Original file line number	Diff line number	Diff line change
`@@ -1124,7 +1124,7 @@ def user_group_create(`
`1124`	`1124`	`m18n.n("group_already_exist_on_system_but_removing_it", group=groupname)`
`1125`	`1125`	`)`
`1126`	`1126`	`subprocess.check_call(`
`1127`		`- f"sed --in-place '/^{groupname}:/d' /etc/group", shell=True`
	`1127`	`+ ["sed", "--in-place", f"/^{groupname}:/d", "/etc/group"]`
`1128`	`1128`	`)`
`1129`	`1129`	`else:`
`1130`	`1130`	`raise YunohostValidationError(`