Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported bars have silence at end #80

Open
glaslan opened this issue Feb 27, 2025 · 6 comments
Open

Exported bars have silence at end #80

glaslan opened this issue Feb 27, 2025 · 6 comments
Labels
enhancement A new feature or feature improvement
Milestone

Comments

@glaslan
Copy link

glaslan commented Feb 27, 2025

When exporting specific bars of a song, the resulting wav file has silence at the end. This makes it difficult to export loopable sections of songs.

Steps to reproduce:

  1. Export specific bars of a song as a wav file.

  2. Open the resulting wav in an editor like Audacity.

  3. Note the silence at the end of the file.

@YuriSizov
Copy link
Owner

Hey! This is done on purpose to allow for residual sounds to finish. At some point it should be improved by detecting prolonged periods of silence at the end. Could also implement some form of trimming after the fact and cull all empty trailing data points.

@YuriSizov YuriSizov added the enhancement A new feature or feature improvement label Feb 27, 2025
@YuriSizov YuriSizov added this to the 3.2 milestone Feb 27, 2025
@snowphun
Copy link

First: Great work. Im a game dev teacher using Bosca in my class.

An option for a clean cut when exporting would be very useful for looping purposes. Im currently working on a layering system in a game with looping layers of different lengths on top of each other. The files length (the loops) need to be of exact length to add and loop corectly. One option to make the loops really good is to have a clean cut, then add the residual sound to the beginning(on top) of the file.

Keep up the good work :-)

@YuriSizov
Copy link
Owner

@snowphun I see your point, and it's certainly possible to add some export option to overlay residual sound on top of the beginning of the song.

But I'm wondering if this wouldn't be better handled by a crossfade on the game engine's side? So the transition isn't baked in, and you can have a clear fade in and fade out if necessary.

@NeuroNoNeuro
Copy link

Will agree with others - loop export of exact length is necessary. Not just for perfectly ordinary music that has to be looped right, but for other types of music (see tape-loop style). Often, music that is not ordinary has imprecisely looped pieces intentionally.

This is why I love the tuplet option that is available as well. Can create pieces that are 'wrong', because it's gorgeous!

@snowphun
Copy link

@YuriSizov I see the benefit of having the option to bake the crossfade into the engine, but i still need to know exact how long the loop lasts. My biggest issue right now is that i dont know the exact length of the bars before i export. So after i export them i have a ton of work in Audacity to cut all the different loops, so they line up and are loopable.

@YuriSizov
Copy link
Owner

@snowphun Fair point, the exact time of the song is not necessarily obvious. Would it be helpful to show such info in the export dialog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or feature improvement
Projects
None yet
Development

No branches or pull requests

4 participants