Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API when cheater-detection is disabled #698

Open
conradoplg opened this issue Jul 3, 2024 · 0 comments
Open

Improve API when cheater-detection is disabled #698

conradoplg opened this issue Jul 3, 2024 · 0 comments

Comments

@conradoplg
Copy link
Contributor

conradoplg commented Jul 3, 2024

When cheater detection disabled, the Coordinator doesn't need to pass PublicKeyPackage::verifying_shares since it's not used anymore. But they still need to choose identifiers to use in the signature_shares BTreeMap argument.

Ideally, when cheater-detection is disabled, this argument could become a BTreeSet, though I feel it's awkward to have a function have different arguments depending on a feature.

Alternativelly we could add another function, e.g. aggregate_without_cheater_detection (and then we could deprecate the cheater-detection feature)

@mpguerra mpguerra moved this to Product Backlog in FROST Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant