Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Default impls with unimplemented! #1

Open
conradoplg opened this issue Nov 19, 2021 · 0 comments
Open

Remove Default impls with unimplemented! #1

conradoplg opened this issue Nov 19, 2021 · 0 comments

Comments

@conradoplg
Copy link
Contributor

Using DefaultIsZeroes requires us to implement Default on SpendAuth and Binding, but those are supposed to be unconstructable. This was solved by adding a Default impl which calls unimplemented! but that doesn't seem ideal.

Check for an alternative and remove the Default impls. One possibility is to explicitly implement Zeroize and Drop. See https://github.com/ZcashFoundation/redjubjub/pull/87/files#r628834530 and ZcashFoundation/redjubjub@2745d37 for context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant