Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Make the number of spends and outputs for each pool available #8980

Open
daira opened this issue Oct 29, 2024 · 0 comments
Open

feature: Make the number of spends and outputs for each pool available #8980

daira opened this issue Oct 29, 2024 · 0 comments
Labels
C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage

Comments

@daira
Copy link
Contributor

daira commented Oct 29, 2024

Motivation

I frequently (well, sometimes) want to know the size of the nullifier set and commitment tree for a shielded pool. (I've used "spends" and "outputs" in the issue title because that terminology also makes sense for the transparent pool.)

This corresponds to zcash/zcash#6751, which is unlikely to be implemented now that zcashd is being deprecated. It doesn't matter whether this info is made available via the RPC interface or another interface.

Describe the solution you'd like

For each pool in the "valuePools" array of the getblockchaininfo output, include:

  • "spends" (numeric) the total number of spends from this pool
  • "outputs" (numeric) the total number of outputs created in this pool

The top-level "commitments" field (I don't know whether zebrad ever had this field) could be deprecated since it will be identical to the "outputs" field for the Sprout pool.

Alternatives you've considered

This information could be given by a separate RPC, but there is an obvious place to put it in the getblockchaininfo output, and I think it is easy to calculate so should not slow down the RPC.

Specifications

No consensus change.

Complex Code or Requirements

No changes to complex code.

Testing

This can be tested relatively straightforwardly against regtest.

Related Work

zcash/zcash#6751

@daira daira added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Oct 29, 2024
@github-project-automation github-project-automation bot moved this to New in Zebra Oct 29, 2024
@mpguerra mpguerra moved this from New to Product Backlog in Zebra Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant