Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial duplicate nullifier checks to transaction verifier #8984

Open
arya2 opened this issue Oct 31, 2024 · 0 comments
Open

Add partial duplicate nullifier checks to transaction verifier #8984

arya2 opened this issue Oct 31, 2024 · 0 comments
Labels
A-concurrency Area: Async code, needs extra work to make it work properly. A-consensus Area: Consensus rule updates P-Optional ✨

Comments

@arya2
Copy link
Contributor

arya2 commented Oct 31, 2024

Motivation

The write block task in zebra-state is currently responsible for validating that there are no duplicate nullifiers in candidate blocks before they are committed to the state, but it checks this sequentially, one block at a time. It could be faster to check at least part of the chain in parallel in the transaction verifier so Zebra can often check only the non-finalized and in-memory state.

Note

There are currently many other opportunities to optimize Zebra's performance, their impact and expected implementation effort by comparison should be considered before this is scheduled.

@arya2 arya2 added A-concurrency Area: Async code, needs extra work to make it work properly. A-consensus Area: Consensus rule updates P-Optional ✨ labels Oct 31, 2024
@github-project-automation github-project-automation bot moved this to New in Zebra Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-concurrency Area: Async code, needs extra work to make it work properly. A-consensus Area: Consensus rule updates P-Optional ✨
Projects
Status: New
Development

No branches or pull requests

1 participant