Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade scrappy #29

Open
ZoranPandovski opened this issue Oct 27, 2019 · 3 comments
Open

Upgrade scrappy #29

ZoranPandovski opened this issue Oct 27, 2019 · 3 comments
Labels
enhancement hacktoberfest help wanted up-for-grabs

Comments

@ZoranPandovski
Copy link
Owner

Upgrade Scrappy to the newest version available and test implementation.
@elwinmartin
Copy link

elwinmartin commented Oct 29, 2019 •
edited
Loading

I'll check if this works really quick.

Edit: it looks like bumping all the way up to 1.8.0 (which was tagged last night) is fine. The minor bump from 1.7.3 to 1.7.4 shouldn't impact any interfaces.

What would you want to see specifically? All I did was run it against "trainers".

@krishnaprasanthg
Copy link
Contributor

I updated only till 1.7.3 as its stable release

@ZoranPandovski
Copy link
Owner Author

Can you push your changes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest help wanted up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krishnaprasanthg @elwinmartin @ZoranPandovski