You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
River_return_condition tests for EFDTNumericBinaryBranch. This needs to be generalised to also support VFDT (HoeffdingTreeClassifier) which uses NumericBinaryBranch (which EFDTNumericBinaryBranch inherits from)
This results in the following exception when run on a HoeffdingTreeClassifier rather than a ExtremelyFastDecisionTreeClassifier
Traceback (most recent call last):
File "/home/anj/src/paper-decision-trees/tree_diff2/experiment2.py", line 260, in eval_efdt
batch1_rules = Ruleset(river_extract_rules(model_batch._root,river_children, river_is_leaf))
File "/home/anj/src/paper-decision-trees/tree_diff2/tree_diff/tree_ruleset_conversion.py", line 137, in river_extract_rules
return [river_create_rule(p) for p in walk_tree(tree, children, is_leaf)]
File "/home/anj/src/paper-decision-trees/tree_diff2/tree_diff/tree_ruleset_conversion.py", line 137, in <listcomp>
return [river_create_rule(p) for p in walk_tree(tree, children, is_leaf)]
File "/home/anj/src/paper-decision-trees/tree_diff2/tree_diff/tree_ruleset_conversion.py", line 133, in river_create_rule
return Rule(conditions=river_create_conditions(path[0:-1]), label=f"{label}")
File "/home/anj/src/paper-decision-trees/tree_diff2/tree_diff/tree_ruleset_conversion.py", line 123, in river_create_conditions
return [river_return_condition(c) for c in path_conds]
File "/home/anj/src/paper-decision-trees/tree_diff2/tree_diff/tree_ruleset_conversion.py", line 123, in <listcomp>
return [river_return_condition(c) for c in path_conds]
File "/home/anj/src/paper-decision-trees/tree_diff2/tree_diff/tree_ruleset_conversion.py", line 119, in river_return_condition
raise ValueError(node)
ValueError: NumericBinaryBranch
River_return_condition
tests forEFDTNumericBinaryBranch
. This needs to be generalised to also support VFDT (HoeffdingTreeClassifier) which usesNumericBinaryBranch
(whichEFDTNumericBinaryBranch
inherits from)This results in the following exception when run on a HoeffdingTreeClassifier rather than a ExtremelyFastDecisionTreeClassifier
See the following notebook for a demonstration of the issue: https://github.com/a2i2/tree_diff/blob/re-evaluation/notebooks/Similarity%20Score%20Issues%20-%20VFDT.ipynb
The text was updated successfully, but these errors were encountered: