Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The enemy system sucks and should be rewritten #130

Open
JohnathonNow opened this issue Feb 6, 2020 · 1 comment
Open

The enemy system sucks and should be rewritten #130

JohnathonNow opened this issue Feb 6, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@JohnathonNow
Copy link
Collaborator

I question a lot of the design decisions here. Why is the enemy rulebook loaded in like it is? And why does enemy_add take in the list of attributes, rather than copying them from the rulebook, and then scaled according to the floor scaling rules? Also a lot of the logic seems scattered about - perhaps some wires should be tugged around.

@dnabre
Copy link
Contributor

dnabre commented Oct 15, 2020

Separating the enemy data (along with items) from the code really helps keep things manageable. It also lets people that aren't comfortable working C code be able to contribute game data easily.

Something like a json file with the enemy data entries. Grouped by type, or even each one in separate file (easy to work with, but scaling may be an issue).

Those data files could used as is in the final build, pulled together into a data file, or even converted in automated way to be compiled into the executable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants