[+/-] bugfix in condition 1

Author: aayux

README.md

@@ -1,8 +1,6 @@
 ## Pymoebots: Stochastic Algorithms Simulator for the Amoebot Model
 
-[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT) [![build status](
-  http://img.shields.io/travis/aayux/pymoebots/master.svg?style=flat)](
- https://travis-ci.com/aayux/pymoebots.svg?token=5ykcpxpsSYeM1yqgzqww&branch=master)
+[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT) [![Build Status](https://travis-ci.com/aayux/pymoebots.svg?token=5ykcpxpsSYeM1yqgzqww&branch=master)](https://travis-ci.com/aayux/pymoebots)
 
 ### Acknowledgements
 

amoebot/elements/bot/functional.py

@@ -343,13 +343,21 @@ def _verify_compression_property_1(
         G[ix] = [ix_lookup[_n] for _n in node_neighbors \
                                         if _n in neighborhood]
 
+    # an empty list to store visited status for each neighbour
+    connectivity = None
+
     graph = GraphAlgorithms(G)
     for n in common_neighbors:
-        # bfs each common neighbour to find a path in the union
-        connectivity += graph.bfs(root=ix_lookup[n])
+        # dfs each common neighbour to find a path in the union
+        if connectivity is None:
+            connectivity = graph.dfs(root=ix_lookup[n])
+        else:
+            connectivity = np.logical_or(
+                                            connectivity, 
+                                            graph.dfs(root=ix_lookup[n])
+                                        )
 
-    if connectivity == len(common_neighbors): return np.uint8(1)
-    else: return np.uint8(0)
+    return np.uint8(np.all(connectivity))
 
 def _verify_compression_property_2(
                                     nmap:defaultdict, 
@@ -409,7 +417,7 @@ def _verify_compression_property_2(
     graph_h, graph_t = GraphAlgorithms(G_h), GraphAlgorithms(G_t)
     for graph in [graph_h, graph_t]:
         # dfs each subgraph and find a path connecting it
-        connectivity += graph.dfs(root=0)
+        connectivity += np.uint8(np.all(graph.dfs(root=0)))
 
     if connectivity == 2: return np.uint8(1)
     else: return np.uint8(0)

amoebot/elements/bot/manager.py

@@ -146,13 +146,13 @@ def exec_sequential(
         self.shared = SharedObjects(self.config_num, data=self.amoebots)
 
         # iteratively execute the algorithm over each amoebot for fixed rounds
-        for _ in range(max_rnds):
+        for iter_ in range(max_rnds):
             exec_seq = list(self.amoebots.keys())
             np.random.shuffle(exec_seq)
             for __id in exec_seq:
                 amoebot_t = (__id, self.amoebots[__id])
                 self.amoebots[__id] = self._exec_one_step(
-                                                            amoebot_t, 
+                                                            amoebot_t, iter_, 
                                                             algorithm=algorithm, 
                                                             async_mode=False
                                                         )
@@ -197,6 +197,7 @@ def _exec_async_with_interpreter_lock(
     def _exec_one_step(
                         self, 
                         amoebot_t:tuple, 
+                        iter_:int=1, 
                         algorithm:str=None, 
                         async_mode:bool=True
                     ) -> Agent:
@@ -207,6 +208,8 @@ def _exec_one_step(
 
             amoebot_t (tuple) :: a tuple with `Agent` and its respective 
                         identifier.
+            iter_ (int) default: 1 :: the current iteration number,
+                        defaults to 1 when all iterations are saved.
             algorithm (str) default: None :: algorithm being performed in 
                         current step, one of "random_move" and "compress"...
             async_mode (bool) default: True :: if True, execute the local, 
@@ -236,7 +239,6 @@ def _exec_one_step(
                     amoebot.tail, 
                     amoebot.tau0
                 )
-
-        self.tracker.update(__id, state)
+        if iter_ % 1 == 0: self.tracker.update(__id, state)
 
         return amoebot

amoebot/elements/node/core.py

@@ -135,13 +135,13 @@ def get_all_ports(self) -> np.ndarray:
 
     @property
     def is_occupied(self) -> bool:
-        return np.uint8(1) if self.occupied is not 0 else np.uint8(0)
+        return np.uint8(1) if self.occupied != 0 else np.uint8(0)
 
     @property
     def is_trace(self) -> bool:
-        return np.uint8(1) if self.occupied is 2 else np.uint8(0)
+        return np.uint8(1) if self.occupied == 2 else np.uint8(0)
 
     @property
     def is_wall(self) -> bool:
-        return np.uint8(1) if self.occupied is 3 else np.uint8(0)
+        return np.uint8(1) if self.occupied == 3 else np.uint8(0)
 

amoebot/utils/graphs.py

@@ -43,8 +43,7 @@ def bfs(self, root:int) -> np.uint8:
                     visited[u] = np.uint8(1)
                     queue.append(u)
 
-        if np.all(visited): return np.uint8(1)
-        return np.uint8(0)
+        return visited
 
     def dfs(self, root:int) -> np.uint8:
         r"""
@@ -68,5 +67,4 @@ def dfs(self, root:int) -> np.uint8:
                     visited[u] = np.uint8(1)
                     stack.append(u)
 
-        if np.all(visited): return np.uint8(1)
-        return np.uint8(0)
+        return visited