Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the docker image #144

Open
azukaar opened this issue Sep 15, 2024 · 3 comments
Open

Publish the docker image #144

azukaar opened this issue Sep 15, 2024 · 3 comments

Comments

@azukaar
Copy link

azukaar commented Sep 15, 2024

Not having the image publish sort of defeat the purpose of having a docker image, it would be nice to have it published to docker hub (you can have a github CI script to auto publish on commit)

abdeladim-s added a commit that referenced this issue Sep 16, 2024
abdeladim-s added a commit that referenced this issue Sep 16, 2024
@abdeladim-s
Copy link
Owner

@azukaar, Yes, having the image pre-built is great. I've wanted to do this for a while but haven't had the chance.
I've quickly created a GitHub action and pushed the image to Docker Hub. You can find it here.
Hope this helps.

@azukaar
Copy link
Author

azukaar commented Sep 17, 2024

amazing thanks
EDIT: just tested it, it seems to work but I noticed you are using :main as a tag, but the best practice is to use :latest
at it is the one that allows docker to auto-chose label

@abdeladim-s
Copy link
Owner

I just followed and used the action from the Github docs.
I believe main refers to the main branch and is set automatically here.
I think the problem is that metadata-action only sets the latest tag if the main branch is called master and I need to add a hack to make it work with main. Will look into that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants