Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build library in Release configuration in CI too #68

Open
lawrence-forooghian opened this issue Sep 26, 2024 · 0 comments
Open

Build library in Release configuration in CI too #68

lawrence-forooghian opened this issue Sep 26, 2024 · 0 comments
Labels
build Relates to the tooling used to build or release the contents of this repository.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Sep 26, 2024 •
edited by sync-by-unito bot
Loading

To catch anything that's incorrectly gated behind a #if DEBUG, for example.

┆Issue is synchronized with this Jira Task by Unito
@lawrence-forooghian lawrence-forooghian added the build Relates to the tooling used to build or release the contents of this repository. label Sep 26, 2024
lawrence-forooghian added a commit that referenced this issue Sep 30, 2024
@lawrence-forooghian
Add a convention for exposing APIs to tests
982b15d 
I had noticed that I was writing lots of comments like "Exposed for
testing" and thought it would be useful to do something more consistent
and lintable.

I’ve gated the code for re-exposing APIs behind a #if DEBUG, to avoid
bloating release builds. Now that there’s a divergence between the Debug
and Release configuration, we should update CI to also build in the
Release configuration; have created #68 for this.
lawrence-forooghian added a commit that referenced this issue Sep 30, 2024
@lawrence-forooghian
Add a convention for exposing APIs to tests
5ab7b44 
I had noticed that I was writing lots of comments like "Exposed for
testing" and thought it would be useful to do something more consistent
and lintable.

I’ve gated the code for re-exposing APIs behind a #if DEBUG, to avoid
bloating release builds. Now that there’s a divergence between the Debug
and Release configuration, we should update CI to also build in the
Release configuration; have created #68 for this.
lawrence-forooghian added a commit that referenced this issue Sep 30, 2024
@lawrence-forooghian
Add a convention for exposing APIs to tests
9fa91c6 
I had noticed that I was writing lots of comments like "Exposed for
testing" and thought it would be useful to do something more consistent
and lintable.

I’ve gated the code for re-exposing APIs behind a #if DEBUG, to avoid
bloating release builds. Now that there’s a divergence between the Debug
and Release configuration, we should update CI to also build in the
Release configuration; have created #68 for this.
@lawrence-forooghian lawrence-forooghian mentioned this issue Sep 30, 2024
Merged
lawrence-forooghian added a commit that referenced this issue Sep 30, 2024
@lawrence-forooghian
Add a convention for exposing APIs to tests
af41348 
I had noticed that I was writing lots of comments like "Exposed for
testing" and thought it would be useful to do something more consistent
and lintable.

I’ve gated the code for re-exposing APIs behind a #if DEBUG, to avoid
bloating release builds. Now that there’s a divergence between the Debug
and Release configuration, we should update CI to also build in the
Release configuration; have created #68 for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Relates to the tooling used to build or release the contents of this repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lawrence-forooghian