Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTN11d spec point implemented incorrectly #1074

Open
ttypic opened this issue Mar 10, 2025 · 0 comments
Open

RTN11d spec point implemented incorrectly #1074

ttypic opened this issue Mar 10, 2025 · 0 comments
Labels
enhancement New feature or improved functionality.

Comments

@ttypic
Copy link
Contributor

ttypic commented Mar 10, 2025

RTN11d spec point implemented incorrectly, it states:

(RTN11d) If the state is CLOSED or FAILED, transitions all the channels to INITIALIZED and unsets their RealtimeChannel.errorReason, unsets the Connection.errorReason, clears all connection state (including in particular Connection.recoveryKey), and resets the msgSerial to 0

Current implementation:

 connection.on(ConnectionEvent.closed, new ConnectionStateListener() {
            @Override
            public void onConnectionStateChanged(ConnectionStateListener.ConnectionStateChange state) {
                channels.clear();
            }
        });

It doesn't handle "failed" termination state and clears channels instead of reseting. Because of that channels can become orphan and won't receive state changes

┆Issue is synchronized with this Jira Task by Unito

@ttypic ttypic added the enhancement New feature or improved functionality. label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

No branches or pull requests

1 participant