Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for flag gpgpu_perf_sim_memcpy #327

Open
sun-lingyu opened this issue Aug 29, 2024 · 1 comment
Open

Bug fix for flag gpgpu_perf_sim_memcpy #327

sun-lingyu opened this issue Aug 29, 2024 · 1 comment

Comments

@sun-lingyu
Copy link

Hi.

Thank you for your great work of accel-sim!

We find a bug which makes the -gpgpu_perf_sim_memcpy flag not working.

In accel-sim-framework/gpu-simulator/gpgpu-sim/src/gpgpu-sim/gpu-sim.cc, the type of variable wr_addr should be size_t instead of unsigned. Otherwise, it leads to an unexpected type conversion and stores a wrong address in wr_addr.

Since this is a tiny fix, I prefer not to border open a new pull request. Maybe you can fix it soon.

Again thank you very much! :)

@JRPan
Copy link
Collaborator

JRPan commented Sep 23, 2024

Thank you. You can submit a PR if you want. And you can become a collaborator :)

It would be the same process for us as well. So don't worry about it.

Thanks for pointing it out anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants