Merge pull request #45 from acisops/Collection_of_LR_Updates

LR updates: run_models.py, OBSID timing error fix

Author: Gregg140

Adjust_ACIS-Continuity.py

@@ -22,6 +22,9 @@
                                               The ACIS-Continuity.txt file adjustment will be SCS-107  for S107
                                               or STOP for Full Stops.
 
+                                              The NLET file is not modified. It is only used only to determine the type of load
+                                              interruption.
+ 
 The graphical timeline representation of events:
 
 | Continuity-Continuity Load|    
@@ -30,7 +33,13 @@
 
                       | Continuity load built, Reviewed and Approved prior to the interrupt |
 
-                                                                                                               |    Review Load |                                          
+                          
+                                                                                                             |    Review Load |                   
+
+Update: July 23, 2025
+              Gregg Germain
+              Comment updates
+                       
 """
 # Create a parser instance
 myparser = argparse.ArgumentParser()

CHECK_POWER_COMMANDS/Check_Power_Cmds.py

@@ -1,7 +1,7 @@
 ################################################################################
 #
 #  Check_Power_Cmds - Check the power command spacing in the load to see if the
-#                     rules ahve been adhered to. Any errors are inserted into a
+#                     rules have been adhered to. Any errors are inserted into a
 #                     new ACIS-LoadReviews.dat file.
 #
 #                     For the time being, this new file is kept separate from
@@ -25,13 +25,12 @@
 #         - Removed deprecated Chandra.Time
 #         - Eliminated commented-out line
 #
-# Update: February 15, 2022
+# Update: July 23, 2025
 #          Gregg Germain
 #          - Allow for the case of a Vehicle-Only Review load where there are no ACISPKT commands
 #
 ################################################################################
 import argparse
-
 import glob
 
 # bring in the system state class
@@ -162,7 +161,7 @@ def run_one_command(cmd, system_state, bfc, rule_set):
     If it did not, then stop.
 """
 # Using ARGPARSE
-cl_parser = argparse.ArgumentParser(description='WeeklyPDAMS plots')
+cl_parser = argparse.ArgumentParser(description='Check Power Commands program')
 
 # Add the TEST argument as NON-POSITIONAL.  
 cl_parser.add_argument("-t", '--test', help='In test mode, plots are not moved to htdocs', action="store_true")
@@ -207,7 +206,7 @@ def run_one_command(cmd, system_state, bfc, rule_set):
 
 
 # If this is a Vehicle-Only Review load then there will be no ACISPKT commands within the load.
-# So skip the while loop which is intended ot take you to the first one.  
+# So skip the while loop which is intended to take you to the first one.  
 # This means that array_row_number will equal 0
 
 if 'ACISPKT' in system_packets['cmd_type']:
@@ -298,7 +297,7 @@ def run_one_command(cmd, system_state, bfc, rule_set):
 
     # Append any violations you found to the master violations list
     if violations_list:
-        all_violations+= violations_list[0]
+        all_violations += violations_list[0]
 
 
 if len(all_violations) == 0:

Release_Notes_V5.0.txt

@@ -0,0 +1,79 @@
+Change Description
+==================
+
+lr is the ACIS Operations  review load processing program. Updates were made to lr and to several of the
+other programs lr executes.
+
+lr, itself, was modified to fix an IF statement that incorrectly analyzed if a load was of the type TOO and the
+continuity load is Vehicle Only. lr was also  modified to call the new run_models.py which replaces run_models.pl
+
+The following updated programs are excuted by lr:
+
+run_models.py was written to continue the conversion of load review programs from Perl to Python. run_models.py included
+a new switch allowing for easier unit testing on existing Production loads.  No interface changes.
+
+acisbackstop.pl was modified to eliminate false errors generated when calculating the time delta
+between an observation's Stop Science command and the next command to change the Obsid.
+
+Check_Power_Cmds.py was modified to be more efficient by avoiding the ACISPKT processing loop when processing a
+Vehicle Only load.
+
+Other updates includes fixing typos and making comments more clear.
+
+
+
+
+
+
+Files Changed or added:
+=======================
+
+
+The updates can be seen here:
+
+https://github.com/acisops/lr/pull/45
+
+
+Testing:
+======== 
+
+Unit tests were carried out by running  test scenarios on all the updated  programs except lr.
+
+Then full regression tests were carried out by arranging for the updated lr to call the new
+ programs on Normal, TOO, SCS-107-only and Full Stop loads and loads with and without Vehicle Only Continuity loads. ACIS-LoadReview.txt output files and
+thermal model plots were compared and all differences were understood. 
+
+
+The production loads involved were:
+
+JUL1425A
+APR2825A
+MAY0525A
+MAR2625A
+MAR2725A
+JAN1525A
+
+JAN2624A
+OCT1324A & B
+
+All tests passed.
+
+
+
+Interface impacts
+=================
+
+None
+
+
+Review
+====== 
+
+ACIS Ops
+
+
+Deployment Plan
+===============
+
+Will be deployed after FSDS approval.
+