Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after svelte-maplibre refactor #359

Open
7 of 12 tasks
dabreegster opened this issue Oct 2, 2023 · 0 comments
Open
7 of 12 tasks

Cleanup after svelte-maplibre refactor #359

dabreegster opened this issue Oct 2, 2023 · 0 comments

Comments

@dabreegster
Copy link
Contributor

dabreegster commented Oct 2, 2023

  • Plumb paint properties in InterventionColorSelector instead of setting directly
  • Rethink behavior of multiple overlapping features, especially for the LPA layer
  • Rethink the route and polygon .ts tools managing sources/layers, and maybe cleanup the old maplibre util functions
  • Stop using the gjScheme store in the browse page
  • Use svelte-maplibre for the critical entry draggable marker (only geocode on dragend)
  • Use svelte-maplibre for the line measurement tool
  • Update dev docs (some HMR guidance refers to old methods)
  • Consider new UX patterns, like showing a popup both on hover, and then making it "sticky" when clicked
  • Revisit interactiveMapLayersEnabled and make sure browse layers are inactive when other tools are active. Try an invisible layer that covers everything?
  • Improve critical clustering (see below)
  • Changing schemes in the browse page doesn't update Filters immediately, or has odd behavior when a text filter is in-place
  • Layer z-ordering may not be consistent (related to beforeId upgrades dimfeld/svelte-maplibre#25 ?)

Critical clustering has changed and feels a bit more buggy to me. I can't figure out why yet; svelte-maplibre seems to plumb through the cluster options just fine. Before:
Screenshot from 2023-10-02 12-00-59
After:
Screenshot from 2023-10-02 12-02-16
Note some of the text counts don't show up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant