From 26a4993608cc60320910e06a25e13cebbddf3b6a Mon Sep 17 00:00:00 2001
From: xrkffgg <xrkffgg@gmail.com>
Date: Fri, 1 Nov 2024 17:17:17 +0800
Subject: [PATCH] chore: remove warning (#197)

* fix: remove warning

* chore: update
---
 .github/workflows/preview-build.yml  | 6 +++---
 .github/workflows/preview-deploy.yml | 8 ++++----
 src/helper/helper.ts                 | 2 --
 3 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/preview-build.yml b/.github/workflows/preview-build.yml
index b82da3ad..732eb62e 100644
--- a/.github/workflows/preview-build.yml
+++ b/.github/workflows/preview-build.yml
@@ -1,6 +1,6 @@
 name: Preview Build
 
-on: 
+on:
   pull_request:
     types: [opened, synchronize, reopened]
 
@@ -22,7 +22,7 @@ jobs:
           zip -r dist.zip docs-dist
 
       - name: upload dist artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: dist
           path: dist.zip
@@ -34,7 +34,7 @@ jobs:
 
       - name: Upload PR number
         if: ${{ always() }}
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: pr
           path: ./pr-id.txt
diff --git a/.github/workflows/preview-deploy.yml b/.github/workflows/preview-deploy.yml
index 13b2387e..9d71dde9 100644
--- a/.github/workflows/preview-deploy.yml
+++ b/.github/workflows/preview-deploy.yml
@@ -12,7 +12,7 @@ jobs:
     if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'success'
     steps:
       - name: download pr artifact
-        uses: dawidd6/action-download-artifact@v2
+        uses: dawidd6/action-download-artifact@v6
         with:
           workflow: ${{ github.event.workflow_run.workflow_id }}
           name: pr
@@ -22,7 +22,7 @@ jobs:
         run: echo "::set-output name=id::$(<pr-id.txt)"
 
       - name: download dist artifact
-        uses: dawidd6/action-download-artifact@v2
+        uses: dawidd6/action-download-artifact@v6
         with:
           workflow: ${{ github.event.workflow_run.workflow_id }}
           workflow_conclusion: success
@@ -43,7 +43,7 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
           body: |
             🎊 PR Preview has been successfully built and deployed to https://issues-helper-preview-pr-${{ steps.pr.outputs.id }}.surge.sh
-            
+
             <img width="300" src="https://user-images.githubusercontent.com/507615/90250366-88233900-de6e-11ea-95a5-84f0762ffd39.png">
 
             <!-- Sticky Pull Request Comment -->
@@ -69,7 +69,7 @@ jobs:
     if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'failure'
     steps:
       - name: download pr artifact
-        uses: dawidd6/action-download-artifact@v2
+        uses: dawidd6/action-download-artifact@v6
         with:
           workflow: ${{ github.event.workflow_run.workflow_id }}
           name: pr
diff --git a/src/helper/helper.ts b/src/helper/helper.ts
index 7082719e..5e4536ea 100644
--- a/src/helper/helper.ts
+++ b/src/helper/helper.ts
@@ -80,8 +80,6 @@ export class IssueHelperEngine implements IIssueHelperEngine {
     const issueNumber = core.getInput('issue-number') || defaultCtxNumber;
     if (issueNumber) {
       this.issueNumber = +issueNumber;
-    } else {
-      core.warning(`'issue-number' is missing or this action not needed yet!`);
     }
 
     this.emoji = core.getInput('emoji') || '';