Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

clippy does not show as failed in workflow #2

Open
1 of 3 tasks
ignatenkobrain opened this issue Jun 6, 2020 · 0 comments
Open
1 of 3 tasks

clippy does not show as failed in workflow #2

ignatenkobrain opened this issue Jun 6, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@ignatenkobrain
Copy link

Do the checklist before filing an issue:

Description

When clippy exits with an error, github workflow is not marked as failed. I think it is not issue with github actions, but I am new to all this and can't judge.

image

Workflow code

https://github.com/ignatenkobrain/zram-generator/blob/9089c94cd416de95faaff0eab9027b5ee90b7365/.github/workflows/ci.yml#L59-L75

Action output

Executing cargo clippy (JSON output)
Clippy exited with 101 code

If I understand code correctly, it just captures return code and always returns 0 unless there is some exception happened in the typescript.

Expected behavior

I am not sure if return code should be compared to 101 or anything else, just would like to make sure that CI blocks on clippy showing any errors.

@ignatenkobrain ignatenkobrain added the bug Something isn't working label Jun 6, 2020
ignatenkobrain added a commit to ignatenkobrain/zram-generator that referenced this issue Jun 6, 2020
Sadly it can't make workflow to fail, but the inline comments are
amazing.

References: actions-rs/clippy#2
Signed-off-by: Igor Raits <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant