Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The custom image of the runner is not used in the templates #3733

Open
4 tasks done
GruemL opened this issue Sep 9, 2024 · 3 comments
Open
4 tasks done

The custom image of the runner is not used in the templates #3733

GruemL opened this issue Sep 9, 2024 · 3 comments
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers

Comments

@GruemL
Copy link

GruemL commented Sep 9, 2024

Checks

Controller Version

0.9.3

Deployment Method

Helm

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

1. install helmchart for gha-runner-scale-set controller and gha-runner-scale set both in version 0.9.3
2. use the custom image path like its described in the [docs](https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/deploying-runner-scale-sets-with-actions-runner-controller#configuring-the-runner-image), but not provided in the [linked values.yaml](https://github.com/actions/actions-runner-controller/blob/master/charts/gha-runner-scale-set/values.yaml) and the [templates](https://github.com/actions/actions-runner-controller/tree/master/charts/gha-runner-scale-set/templates) of the helm chart.

we use it like this:


minRunners: 1
runnerGroup: "qs"
runnerScaleSetName: "ha-test"
template:
  spec:
    containers:
      - name: runner
        image: "IMAGE_PATH/NAME"
        imagePullPolicy: ifNotPresent
        command: ["/home/runner/run.sh"]
    imagePullSecrets:
      - name: SECRETNAME


There are no events or hints in the controller log. The runner pod does not start.

I know there is a discussion for this topic : https://github.com/actions/actions-runner-controller/discussions/2835

But it doesnt help for my problem.

Thank you in advance.

Describe the bug

The Bug is, that the customImage and ImagePullSecret Part from the docs is never used in the values.yaml or in one of the templates.

Or is the part for the listener pod that inherits the imagepullpolicy from the controller pod also valid for the runner pod?

Describe the expected behavior

I can use my custom image and imagepullsecret and it is used in values.yaml and templates like described in the docs.

Additional Context

values.yaml:


minRunners: 1
runnerGroup: "qs"
runnerScaleSetName: "ha-test"
template:
  spec:
    containers:
      - name: runner
        image: "IMAGE_PATH/NAME"
        imagePullPolicy: ifNotPresent
        command: ["/home/runner/run.sh"]
    imagePullSecrets:
      - name: SECRETNAME

Controller Logs

There are no errors in the controller pod logs

Runner Pod Logs

no runner pod is created - no events
@GruemL GruemL added bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers labels Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

@diegoara96
Copy link

The secret with your private registry login is in the same namespace as the helm deployment (arc-runners by default)?

@GruemL
Copy link
Author

GruemL commented Sep 13, 2024

yes, it is in the same namespace. But there are no events that is even used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

2 participants