-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration seems to struggle with Next.js PWA configurations #44
Comments
|
Weird that no workaround or fix has been proposed here |
This action seems to support wrapping calls already, but the functionality for doing so seems to not be enabled. The configure-pages/src/set-pages-config.js Lines 77 to 79 in f156874
The parsing for wrapping calls only seems to allow one wrapping call, though, so multiple higher-order functions would not be usable even if |
* Remove [actions/configure-pages](https://github.com/actions/configure-pages) from workflow due to missing support for wrapping Next.js config in higher-order functions (actions/configure-pages#44)
I've raised a PR to introduce @haykam821's fix here: #161. |
I am working on migrating a web application to Next.js in this repo. However, I am running into an issue where the
basePath
is seemingly not injected.My configuration looks like the following:
However, the step using the
actions/configure-pages
action outputs this warning from #43:Other than the fact that the
next.config.js
configuration uses the.js
extension, it seems that the action fails to inject properties into a configuration wrapped by a higher-orderwithPWA
function. A more useful error is not logged, so this issue is hard to diagnose.The text was updated successfully, but these errors were encountered: