Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assertion for disconnect #40

Open
DivineDominion opened this issue May 10, 2023 · 1 comment · May be fixed by #41
Open

Remove assertion for disconnect #40

DivineDominion opened this issue May 10, 2023 · 1 comment · May be fixed by #41

Comments

@DivineDominion
Copy link
Contributor

WebMIDIKit/Sources/WebMIDIKit/MIDIPortMap.swift

Line 70 in 6f35069

assert(port.state == .connected)

This assertion fires when you unplug a MIDI device of which a port is used.

I think removing this cause for runtime exceptions in DEBUG builds is a good fit (because the assumption that the device is still connected isn't always true!) and cannot gracefully be handled at all.
@DivineDominion
Copy link
Contributor Author

@adamnemecek Gentle ping: what do you think about removing this?

@DivineDominion DivineDominion linked a pull request Jun 5, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove crashing assertions DivineDominion/WebMIDIKit
1 participant
@DivineDominion