Fix: Correcting tests to behave appropriately on courses with multiple drawer items (issue/134) #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e drawer items (issue/134)
cahirodoherty-learningpool
moved this from New
to Needs Reviewing
in adapt_framework: The TODO Board
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test behavior for courses with multiple drawer items by updating test setup and adding a new helper for accessing the resources drawer.
- Update beforeEach in e2e tests to determine if multiple drawer items exist
- Invoke the new accessResourcesDrawer helper in the tests where appropriate
- Introduce the accessResourcesDrawer utility function in helpers.js
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/e2e/pageResources.cy.js | Updates beforeEach to identify multi-drawer scenarios and calls helper |
| test/e2e/menuResources.cy.js | Similar updates as pageResources, ensuring proper drawer access behavior |
| test/e2e/helpers.js | Adds the accessResourcesDrawer helper function to click the correct button |
ethan-lp
approved these changes
May 7, 2025
lemmyadams
approved these changes
May 8, 2025
oliverfoster
requested changes
May 14, 2025
oliverfoster
approved these changes
May 14, 2025
github-project-automation
bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
|
🎉 This PR is included in version 5.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
Fix