Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the docs for contributing up to date? #1704

Closed
2 tasks done
marcusegues opened this issue Jul 8, 2019 · 4 comments
Closed
2 tasks done

Are the docs for contributing up to date? #1704

marcusegues opened this issue Jul 8, 2019 · 4 comments

Comments

@marcusegues
Copy link

Which version of React JS are you using?

☣️ Not officially supported, expect warnings and errors ☣️

  • [ x] v16.x.x

Which browser are you using?

✅ Officially supported ✅

  • Chrome

I'm submitting a ...

  • 💡 Feature Request

Issue Details

I would like to contribute a PR for a small feature request. I followed the instructions in the docs but I seem to be missing something. Where is the npm script that I am supposed to run, dev-server?
The available scripts are in package.json are:

  "scripts": {
    "docs": "node docs/utils/docsGen.js",
    "test": "jest",
    "test-dev": "jest --watch",
    "postinstall": "lerna bootstrap --no-ci",
    "prebuild": "node tools/buildStylesheets.js",
    "build": "lerna run build",
    "build-commonjs": "lerna run build-commonjs",
    "start": "node webpack-dev-server.js",
    "eslint": "eslint --report-unused-disable-directives --ext js,ts,tsx --max-warnings 0 -f codeframe --cache --color packages/react-data-grid/src packages/react-data-grid-addons/src tests examples",
    "fix-eslint": "npm run eslint -- --fix",
    "web": "cd website && npm run start"
  },

If I run yarn run start, I get a server at port 8080 showing nothing.

@marcusegues
Copy link
Author

By the way, the feature request is for this

Being able to define the key in columns definition to support nested objects. The linked issue does offer a way to do it and it works, but I think it breaks things like grouping.

@yusunglee2074
Copy link

yusunglee2074 commented Jul 12, 2019

npm run start

gave me about all example,

ERROR in ./examples/scripts/example0*-built-in-editors.js
Module not found: Error: Can't resolve 'react-data-grid-addons' in '/Users/yusunglee2074/Desktop/study/temp/react-data-grid/examples/scripts'
 @ ./examples/scripts/example06-built-in-editors.js 10:0-61 13:21-28 14:24-34
 @ ./examples/components/Examples.js
 @ ./examples/components/App.js
 @ ./examples/index.js
 @ multi webpack-dev-server/client?http://localhost:8080/ webpack/hot/dev-server ./examples ./packages/react-data-grid/style/react-data-grid.less ./packages/react-data-grid-addons/style/react-data-grid-addons.less ./packages/react-data-grid-addons/node_modules/react-select/dist/react-select.css

@qili26
Copy link
Contributor

qili26 commented Jul 12, 2019

@yusunglee2074
Try run npm run build once and then npm start. I remember it could fix the issue.

nstepien pushed a commit that referenced this issue Dec 13, 2019
@nstepien
Copy link
Contributor

Closing in favor of #2575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants