Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official SDK don't include Dependencies.xml inside Editor folder. #259

Open
thanh-nguyen-kim opened this issue Dec 2, 2022 · 1 comment

Comments

@thanh-nguyen-kim
Copy link

thanh-nguyen-kim commented Dec 2, 2022

In our project, Google External Dependency Manager rewrite mainTemplate.gradle each time we perform a build. This action causes our project to miss 2 android packages:

  • com.android.installreferrer:installreferrer:2.2
  • com.google.android.gms:play-services-ads-identifier:18.0.1

New developer often overlooks this behavior which cause miss-match UA report.

Here is the content of the Dependencies.xml which should be put inside Editor folder.

<dependencies>
  <unityversion>4.32.2</unityversion>
  <androidPackages>
    <androidPackage spec="com.android.installreferrer:installreferrer:2.2" />
</androidPackages>
<androidPackages>
  <androidPackage spec="com.google.android.gms:play-services-ads-identifier:18.0.1" />
</androidPackages>
</dependencies>
@uerceg
Copy link
Contributor

uerceg commented Feb 27, 2025

Hey @thanh-nguyen-kim,

Sorry for quite a delay in replying to this one.

Fair point. 👍 Even though for a lot of users, it would make sense for us to automatically bundle into our Dependencies.xml, we still have users who are not targeting Google Play Store and who might not be super thrilled with us pulling in these dependencies on their behalf. But updating our documentation to state this what you wrote above does sound like a good step forward.

Thank you for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants