Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - handling last sentence in task1_converter.py #38

Open
antonyscerri opened this issue Jan 22, 2020 · 0 comments
Open

Bug - handling last sentence in task1_converter.py #38

antonyscerri opened this issue Jan 22, 2020 · 0 comments

Comments

@antonyscerri
Copy link

Hi

The conversion script task1_converter.py does not handle the last line in all the deft_files where they dont end in a blank line (which is all those in the train subdirectory). The code isn't checking for a new sentences concatenation after going through all the lines.

This brings up another question which is the corpus size in terms of sentences. I've not been able to match up with the figures in the paper against any of the sets of files in this repo, so i wanted to check how many sentences should there in fact be in total.

Thanks

Tony

sashaspala pushed a commit that referenced this issue Jan 28, 2020
…prefixes, fixed task1_converter to always handle final lines as mentioned in #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant