-
-
Notifications
You must be signed in to change notification settings - Fork 100
unixPB: Add role for gcc13 #3975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got this running through VagrantPlaybookCheck just now but I don't expect any problems. I can't remember which distro I built this on but if it wasn't CentOS6 on x64 we'll probably want to exclude that. Can you also adjust the commit message so it's prefixed with unixPB:
please?
I will update the comment. I do need it on cent6 though for jdk8 &11 x64 only. I thought I read a comment from you that indicated it was built on cent6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
Looks like that's not the case :'(
|
Copied from the gcc11 role. Removed support for armv7l. Enabled in the main.yml Playbook. Issue adoptium/temurin-build#4110 Signed-off-by: Adam Brousseau <[email protected]>
Ok. How do we want to proceed? |
I've got a new version that will be suitable for running on EL6 so I'll just replace the tarball with the new one. Didn't realise (or it slipped my mind) that you were updating the GCCs used for the older JDK versions too. I know there were some issues with later GCCs and JDK8 a few months back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to checksum for updated GCC13/x64 tarball compatible with EL6
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/gcc_13/vars/main.yml
Outdated
Show resolved
Hide resolved
…/main.yml Co-authored-by: Stewart X Addison <[email protected]>
LGTM - https://ci.adoptium.net/job/VagrantPlaybookCheck/2132/OS=Ubuntu2404,label=vagrant/console worked with the updated download for Linux/x64. How urgently do you need this in? Could it wait until tomorrow (i.e. after we'll have done most of our July PSU builds?) Next week? |
I think at this point, given the release starts today, we can wait until next week as we probably won't get around to turning it on until towards the end of the month. |
Copied from the gcc11 role.
Removed support for armv7l.
Enabled in the main.yml Playbook.
Issue adoptium/temurin-build#4110
Checklist